From 9cda5a63b12012f8a46def625bfa6841fef4d9ae Mon Sep 17 00:00:00 2001 From: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com> Date: Sun, 21 Jun 2026 23:36:21 +0000 Subject: [PATCH 1/2] =?UTF-8?q?feat:=20implement=20issue=20#874=20?= =?UTF-8?q?=E2=80=94=20[Phase=202]=20Repin=20.github-private's=20feature-i?= =?UTF-8?q?deation.yml=20stub=20to=20the=20feature-ideation/next=20channel?= =?UTF-8?q?=20+=20update=20its=20compliance=20test?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/feature-ideation.yml | 13 ++++++++++++- tests/test_feature_ideation.bats | 25 +++++++++---------------- 2 files changed, 21 insertions(+), 17 deletions(-) diff --git a/.github/workflows/feature-ideation.yml b/.github/workflows/feature-ideation.yml index 2ed100b78..e3eec2d46 100644 --- a/.github/workflows/feature-ideation.yml +++ b/.github/workflows/feature-ideation.yml @@ -100,7 +100,18 @@ jobs: discussions: write id-token: write actions: read - uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@897e4dede3518cdd7273b9dc63e607d0d05cbdda # v1 + # SANCTIONED RING-RELEASE PIN — documented exception to the stub header's + # "You MUST NOT change … the uses: line" rule. This repo is feature-ideation's + # `next` ring (host-relative canary / dogfood-first), so it pins ONCE to the + # moving `feature-ideation/next` channel tag and rides each promotion in place + # — exercising the candidate (folded-enhancement) reusable ahead of every other + # ring. The channel tag is a first-party mutable ref bounded by the + # feature-ideation/** ruleset on petry-projects/.github, NOT an unpinned action; + # a compliance pass must not "fix" it back to a frozen @vX.Y.Z / @. + # See AGENTS.md "Release channel tags & the mutable-ref exception" and + # docs/release/versioning.md (ring channels; Cross-repo: feature-ideation). + # Precedent: auto-rebase.yml intentionally pins its reusable @v2 ahead of canon. + uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@feature-ideation/next with: # On the `discussion: created` trigger this carries the new Discussion's # number → the reusable runs single-idea enhancement mode. Empty on diff --git a/tests/test_feature_ideation.bats b/tests/test_feature_ideation.bats index 0c1e31066..8aae16654 100644 --- a/tests/test_feature_ideation.bats +++ b/tests/test_feature_ideation.bats @@ -2,19 +2,20 @@ # Regression tests for .github/workflows/feature-ideation.yml compliance. # # Guards the invariants checked by the weekly org compliance audit -# (check: non-stub-feature-ideation.yml) to prevent re-filing of the -# "reusable not pinned to @v1" finding (#629). +# (check: non-stub-feature-ideation.yml). The stub now pins the reusable to +# the feature-ideation/next channel tag (the sanctioned ring-release +# mechanism — see the mutable-ref exception in AGENTS.md and +# docs/release/versioning.md) rather than the former @v1 SHA (#629). # # Run with: bats tests/test_feature_ideation.bats FEATURE_IDEATION_YML=".github/workflows/feature-ideation.yml" -# Canonical reusable + v1 pin from +# Canonical reusable + channel pin from # petry-projects/.github/standards/workflows/feature-ideation.yml REUSABLE="petry-projects/.github/.github/workflows/feature-ideation-reusable.yml" -V1_SHA="897e4dede3518cdd7273b9dc63e607d0d05cbdda" -# The superseded pin the audit flagged (#629). -V2_SHA="376a4fcb1117444595e3e702fa450873d0e54310" +# The candidate (folded-enhancement) ring channel this repo (next/dogfood) pins to. +CHANNEL="feature-ideation/next" setup() { # Run tests from repo root so relative paths resolve correctly. @@ -29,14 +30,6 @@ setup() { grep -qF "uses: ${REUSABLE}@" "$FEATURE_IDEATION_YML" } -@test "feature-ideation.yml pins the reusable to the v1 SHA (compliance-audit check)" { - grep -qF "uses: ${REUSABLE}@${V1_SHA}" "$FEATURE_IDEATION_YML" -} - -@test "feature-ideation.yml uses: line is annotated # v1" { - grep -qE "uses: ${REUSABLE}@${V1_SHA}[[:space:]]+# v1" "$FEATURE_IDEATION_YML" -} - -@test "feature-ideation.yml is not pinned to the superseded v2 SHA" { - [ -f "$FEATURE_IDEATION_YML" ] && ! grep -qF "$V2_SHA" "$FEATURE_IDEATION_YML" +@test "feature-ideation.yml pins the reusable to the feature-ideation/next channel tag" { + grep -qF "uses: ${REUSABLE}@${CHANNEL}" "$FEATURE_IDEATION_YML" } From a50aff6a1236f38ab4a8b5442ce007a774812e5a Mon Sep 17 00:00:00 2001 From: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com> Date: Sun, 21 Jun 2026 23:44:03 +0000 Subject: [PATCH 2/2] chore: apply manual instructions [skip ci-relay] --- tests/test_feature_ideation.bats | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/test_feature_ideation.bats b/tests/test_feature_ideation.bats index 8aae16654..acf488639 100644 --- a/tests/test_feature_ideation.bats +++ b/tests/test_feature_ideation.bats @@ -30,6 +30,7 @@ setup() { grep -qF "uses: ${REUSABLE}@" "$FEATURE_IDEATION_YML" } -@test "feature-ideation.yml pins the reusable to the feature-ideation/next channel tag" { +@test "feature-ideation.yml pins the reusable to the configured channel tag" { + grep -F "uses: ${REUSABLE}@" "$FEATURE_IDEATION_YML" grep -qF "uses: ${REUSABLE}@${CHANNEL}" "$FEATURE_IDEATION_YML" }