From 24accd18ebd1f045b72dda13011fb8536054b5ab Mon Sep 17 00:00:00 2001 From: donpetry-bot <{}+donpetry-bot@users.noreply.github.com> Date: Sun, 14 Jun 2026 12:38:10 +0000 Subject: [PATCH 1/3] =?UTF-8?q?feat:=20implement=20issue=20#677=20?= =?UTF-8?q?=E2=80=94=20[Phase=201]=20Thread=20an=20optional=20MCP=20config?= =?UTF-8?q?=20into=20the=20Claude=20agentic=20review=20tiers=20(engine.sh)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- scripts/engine.sh | 56 +++++++- tests/dev-lead/fixtures/engines/stub-claude | 5 + tests/dev-lead/unit/test_engine_mcp.bats | 152 ++++++++++++++++++++ 3 files changed, 209 insertions(+), 4 deletions(-) create mode 100644 tests/dev-lead/unit/test_engine_mcp.bats diff --git a/scripts/engine.sh b/scripts/engine.sh index d6c94421d..622683561 100644 --- a/scripts/engine.sh +++ b/scripts/engine.sh @@ -46,6 +46,18 @@ DUCK_TIMEOUT_SEC="${DUCK_TIMEOUT_SEC:-300}" RETRY_MAX_ATTEMPTS="${RETRY_MAX_ATTEMPTS:-2}" # total attempts including first RETRY_BASE_DELAY_SEC="${RETRY_BASE_DELAY_SEC:-5}" +# Opt-in MCP (Model Context Protocol) config for the agentic review tiers. +# REVIEW_MCP_CONFIG — path to an MCP-servers JSON config file. When unset/empty +# or not readable, the claude invocations gain NO new flags and behavior is +# byte-for-byte unchanged for every existing adopter. +# REVIEW_MCP_ALLOWED_TOOLS — comma-separated MCP tool names (e.g. +# "mcp__context7__*") merged into the per-tier --allowed-tools list so the +# configured MCP tools are actually permitted. Default empty. +# Only the deep (run_agentic) and rubber-duck (run_duck) claude tiers receive +# this — the triage tier stays fast/restricted (--disallowed-tools only). +REVIEW_MCP_CONFIG="${REVIEW_MCP_CONFIG:-}" +REVIEW_MCP_ALLOWED_TOOLS="${REVIEW_MCP_ALLOWED_TOOLS:-}" + set_engine_config() { case "$REVIEW_ENGINE" in claude) @@ -582,6 +594,34 @@ _record_engine_tokens() { "$input_tokens" "$cache_read_tokens" "$output_tokens" "$context" "$cache_write_tokens" || true } +# _mcp_review_flags +# Threads the opt-in MCP config into the claude agentic/duck tiers. Populates two +# globals for the caller to splice into the claude --print invocation: +# _MCP_ALLOWED_TOOLS — base_allowed_tools with REVIEW_MCP_ALLOWED_TOOLS merged +# in (comma-separated). Equals base when no MCP tools set. +# _MCP_FLAGS — array: (--mcp-config --strict-mcp-config) when +# REVIEW_MCP_CONFIG points to a readable file; empty array +# otherwise. +# Verified against @anthropic-ai/claude-code 2.1.138 (claude --help): +# --mcp-config Load MCP servers from JSON files or strings +# --strict-mcp-config Only use MCP servers from --mcp-config, ignoring +# all other MCP configurations +# When REVIEW_MCP_CONFIG is unset/empty/unreadable, _MCP_FLAGS stays empty and +# _MCP_ALLOWED_TOOLS == base_allowed_tools → no new flags, behavior unchanged. +_mcp_review_flags() { + local base="$1" + _MCP_FLAGS=() + _MCP_ALLOWED_TOOLS="$base" + if [ -n "${REVIEW_MCP_CONFIG:-}" ] && [ -r "${REVIEW_MCP_CONFIG}" ]; then + _MCP_FLAGS=(--mcp-config "$REVIEW_MCP_CONFIG" --strict-mcp-config) + if [ -n "${REVIEW_MCP_ALLOWED_TOOLS:-}" ]; then + _MCP_ALLOWED_TOOLS="${base},${REVIEW_MCP_ALLOWED_TOOLS}" + fi + elif [ -n "${REVIEW_MCP_CONFIG:-}" ]; then + echo " [mcp] REVIEW_MCP_CONFIG='$REVIEW_MCP_CONFIG' is not a readable file — skipping MCP flags" >&2 + fi +} + # run_triage # Used by: review-one-pr.sh only (not the dev-lead writer pipeline). # No-tool mode. The prompt file already has all PR context inlined by the @@ -706,15 +746,19 @@ run_agentic() { if [ -n "$_tier_default" ] && [ "$model" != "$_tier_default" ]; then _agentic_chain="$model" fi + # Thread the opt-in MCP config (no-op when REVIEW_MCP_CONFIG is unset). + _mcp_review_flags "Bash,Read,Grep,Glob" if [ -n "$_tok_tmp" ]; then _claude_chain_invoke "$_agentic_chain" "$prompt_file" "$DEEP_TIMEOUT_SEC" \ --permission-mode acceptEdits \ - --allowed-tools "Bash,Read,Grep,Glob" \ + --allowed-tools "$_MCP_ALLOWED_TOOLS" \ + "${_MCP_FLAGS[@]}" \ | tee "$_tok_tmp" || rc=${PIPESTATUS[0]} else _claude_chain_invoke "$_agentic_chain" "$prompt_file" "$DEEP_TIMEOUT_SEC" \ --permission-mode acceptEdits \ - --allowed-tools "Bash,Read,Grep,Glob" \ + --allowed-tools "$_MCP_ALLOWED_TOOLS" \ + "${_MCP_FLAGS[@]}" \ || rc=$? fi ;; @@ -808,19 +852,23 @@ run_duck() { claude) unset COPILOT_GITHUB_TOKEN 2>/dev/null || true unset GOOGLE_API_KEY 2>/dev/null || true + # Thread the opt-in MCP config (no-op when REVIEW_MCP_CONFIG is unset). + _mcp_review_flags "Bash,Read,Grep,Glob" # Route through the chain helper so real token usage (incl. cache) is captured # when logging is on; a single-model "chain" preserves prior behaviour. if [ -n "$_tok_tmp" ]; then _claude_chain_invoke "$model" "$prompt_file" "$DUCK_TIMEOUT_SEC" \ --permission-mode acceptEdits \ - --allowed-tools "Bash,Read,Grep,Glob" \ + --allowed-tools "$_MCP_ALLOWED_TOOLS" \ --max-turns 25 \ + "${_MCP_FLAGS[@]}" \ | tee "$_tok_tmp" || rc=${PIPESTATUS[0]} else _claude_chain_invoke "$model" "$prompt_file" "$DUCK_TIMEOUT_SEC" \ --permission-mode acceptEdits \ - --allowed-tools "Bash,Read,Grep,Glob" \ + --allowed-tools "$_MCP_ALLOWED_TOOLS" \ --max-turns 25 \ + "${_MCP_FLAGS[@]}" \ || rc=$? fi ;; diff --git a/tests/dev-lead/fixtures/engines/stub-claude b/tests/dev-lead/fixtures/engines/stub-claude index 60d6dcb34..6cd4f091d 100755 --- a/tests/dev-lead/fixtures/engines/stub-claude +++ b/tests/dev-lead/fixtures/engines/stub-claude @@ -12,6 +12,11 @@ # STUB_CLAUDE_USAGE — "input cache_read cache_write output" emitted as the # .usage block when --output-format json is requested. # Default "100 20 30 40". +# STUB_ENGINE_RECORD_ARGS — if set to a writable path, the full argv of every +# invocation is appended as one line for inspection. +if [ -n "${STUB_ENGINE_RECORD_ARGS:-}" ]; then + printf '%s\n' "$*" >> "$STUB_ENGINE_RECORD_ARGS" 2>/dev/null || true +fi model="" output_format="text" while [[ $# -gt 0 ]]; do diff --git a/tests/dev-lead/unit/test_engine_mcp.bats b/tests/dev-lead/unit/test_engine_mcp.bats new file mode 100644 index 000000000..b587d9431 --- /dev/null +++ b/tests/dev-lead/unit/test_engine_mcp.bats @@ -0,0 +1,152 @@ +#!/usr/bin/env bats +# Unit tests for engine.sh — opt-in MCP config threading (issue #677). +# +# Verifies that REVIEW_MCP_CONFIG / REVIEW_MCP_ALLOWED_TOOLS thread the MCP +# flags (--mcp-config --strict-mcp-config) and merged --allowed-tools +# into ONLY the claude branch of the agentic (run_agentic) and rubber-duck +# (run_duck) tiers — never the triage tier — and that the default (knob unset) +# behavior is byte-for-byte unchanged. + +SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../.." && pwd)" +ENGINE_SCRIPT="$SCRIPT_DIR/scripts/engine.sh" +STUB_ENGINES_DIR="$SCRIPT_DIR/tests/dev-lead/fixtures/engines" + +setup() { + export GITHUB_ENV="$(mktemp)" + export GITHUB_OUTPUT="$(mktemp)" + + unset CLAUDE_TRIAGE_MODEL_CHAIN CLAUDE_DEEP_MODEL_CHAIN CLAUDE_AUDIT_MODEL_CHAIN + unset CLAUDE_ACTION_MODEL_CHAIN CLAUDE_SINGLE_MODEL_CHAIN + unset REVIEW_MCP_CONFIG REVIEW_MCP_ALLOWED_TOOLS + + STUB_BIN_DIR="$(mktemp -d)" + cp "$STUB_ENGINES_DIR/stub-claude" "$STUB_BIN_DIR/claude" + cp "$STUB_ENGINES_DIR/stub-gemini" "$STUB_BIN_DIR/gemini" + chmod +x "$STUB_BIN_DIR/claude" "$STUB_BIN_DIR/gemini" + export PATH="$STUB_BIN_DIR:$PATH" + export STUB_BIN_DIR + + TEST_PROMPT="$(mktemp)" + echo "test prompt content" > "$TEST_PROMPT" + export TEST_PROMPT + + ARGS_RECORD="$(mktemp)" + export STUB_ENGINE_RECORD_ARGS="$ARGS_RECORD" + + # A readable MCP config file the helper can point at. + MCP_CONFIG_FILE="$(mktemp)" + echo '{"mcpServers":{}}' > "$MCP_CONFIG_FILE" + export MCP_CONFIG_FILE + + export DEV_LEAD_DRY_RUN="false" + export STUB_ENGINE_EXIT=0 +} + +teardown() { + rm -f "$GITHUB_ENV" "$GITHUB_OUTPUT" "$TEST_PROMPT" "$ARGS_RECORD" "$MCP_CONFIG_FILE" + rm -rf "$STUB_BIN_DIR" + unset STUB_ENGINE_RECORD_ARGS STUB_ENGINE_EXIT + unset REVIEW_MCP_CONFIG REVIEW_MCP_ALLOWED_TOOLS +} + +_source_engine() { + local engine="${1:-claude}" + export REVIEW_ENGINE="$engine" + source "$ENGINE_SCRIPT" 2>/dev/null || true +} + +# ── Default (knob unset): behavior unchanged ────────────────────────────────── + +@test "agentic: no MCP knob → no MCP flags, default allowed-tools unchanged" { + _source_engine "claude" + run run_agentic "$TEST_PROMPT" "claude-opus-4-8" "deep" + [ "$status" -eq 0 ] + ! grep -q -- "--mcp-config" "$ARGS_RECORD" + ! grep -q -- "--strict-mcp-config" "$ARGS_RECORD" + grep -q -- "--allowed-tools Bash,Read,Grep,Glob" "$ARGS_RECORD" +} + +@test "agentic: empty REVIEW_MCP_CONFIG → no MCP flags" { + _source_engine "claude" + export REVIEW_MCP_CONFIG="" + run run_agentic "$TEST_PROMPT" "claude-opus-4-8" "deep" + [ "$status" -eq 0 ] + ! grep -q -- "--mcp-config" "$ARGS_RECORD" +} + +@test "agentic: REVIEW_MCP_CONFIG pointing to unreadable file → no MCP flags" { + _source_engine "claude" + export REVIEW_MCP_CONFIG="/nonexistent/path/mcp-does-not-exist.json" + run run_agentic "$TEST_PROMPT" "claude-opus-4-8" "deep" + [ "$status" -eq 0 ] + ! grep -q -- "--mcp-config" "$ARGS_RECORD" + grep -q -- "--allowed-tools Bash,Read,Grep,Glob" "$ARGS_RECORD" +} + +# ── Knob set: MCP flags threaded into agentic ──────────────────────────────── + +@test "agentic: REVIEW_MCP_CONFIG set → MCP flags appended to claude call" { + _source_engine "claude" + export REVIEW_MCP_CONFIG="$MCP_CONFIG_FILE" + run run_agentic "$TEST_PROMPT" "claude-opus-4-8" "deep" + [ "$status" -eq 0 ] + grep -q -- "--mcp-config $MCP_CONFIG_FILE" "$ARGS_RECORD" + grep -q -- "--strict-mcp-config" "$ARGS_RECORD" +} + +@test "agentic: REVIEW_MCP_ALLOWED_TOOLS merged into --allowed-tools" { + _source_engine "claude" + export REVIEW_MCP_CONFIG="$MCP_CONFIG_FILE" + export REVIEW_MCP_ALLOWED_TOOLS="mcp__context7__*" + run run_agentic "$TEST_PROMPT" "claude-opus-4-8" "deep" + [ "$status" -eq 0 ] + grep -q -- "--allowed-tools Bash,Read,Grep,Glob,mcp__context7__\*" "$ARGS_RECORD" +} + +@test "agentic: MCP config set but no allowed-tools knob → base allowed-tools kept" { + _source_engine "claude" + export REVIEW_MCP_CONFIG="$MCP_CONFIG_FILE" + run run_agentic "$TEST_PROMPT" "claude-opus-4-8" "deep" + [ "$status" -eq 0 ] + grep -q -- "--allowed-tools Bash,Read,Grep,Glob" "$ARGS_RECORD" + ! grep -q -- "--allowed-tools Bash,Read,Grep,Glob," "$ARGS_RECORD" +} + +# ── Knob set: MCP flags threaded into duck ─────────────────────────────────── + +@test "duck: REVIEW_MCP_CONFIG set → MCP flags appended to claude duck call" { + _source_engine "claude" + export DUCK_ENGINE="claude" + export REVIEW_MCP_CONFIG="$MCP_CONFIG_FILE" + export REVIEW_MCP_ALLOWED_TOOLS="mcp__context7__*" + run run_duck "$TEST_PROMPT" "claude-sonnet-4-6" + [ "$status" -eq 0 ] + grep -q -- "--mcp-config $MCP_CONFIG_FILE" "$ARGS_RECORD" + grep -q -- "--strict-mcp-config" "$ARGS_RECORD" + grep -q -- "--allowed-tools Bash,Read,Grep,Glob,mcp__context7__\*" "$ARGS_RECORD" + # The duck tier's existing --max-turns flag must still be present. + grep -q -- "--max-turns 25" "$ARGS_RECORD" +} + +@test "duck: no MCP knob → no MCP flags on claude duck call" { + _source_engine "claude" + export DUCK_ENGINE="claude" + run run_duck "$TEST_PROMPT" "claude-sonnet-4-6" + [ "$status" -eq 0 ] + ! grep -q -- "--mcp-config" "$ARGS_RECORD" + grep -q -- "--allowed-tools Bash,Read,Grep,Glob" "$ARGS_RECORD" +} + +# ── Triage tier: never gets MCP flags ──────────────────────────────────────── + +@test "triage: MCP knob set → triage still uses --disallowed-tools only, no MCP" { + _source_engine "claude" + export REVIEW_MCP_CONFIG="$MCP_CONFIG_FILE" + export REVIEW_MCP_ALLOWED_TOOLS="mcp__context7__*" + run run_triage "$TEST_PROMPT" + [ "$status" -eq 0 ] + ! grep -q -- "--mcp-config" "$ARGS_RECORD" + ! grep -q -- "--strict-mcp-config" "$ARGS_RECORD" + ! grep -q -- "--allowed-tools" "$ARGS_RECORD" + grep -q -- "--disallowed-tools" "$ARGS_RECORD" +} From bef521cac1cc2e5adbf3f6d95996e56fb74e6794 Mon Sep 17 00:00:00 2001 From: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com> Date: Sun, 14 Jun 2026 12:44:09 +0000 Subject: [PATCH 2/3] fix(reviews): address review comments [skip ci-relay] --- scripts/engine.sh | 10 +++++----- tests/dev-lead/unit/test_engine_mcp.bats | 10 ++++++++++ 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/scripts/engine.sh b/scripts/engine.sh index 622683561..d435daea3 100644 --- a/scripts/engine.sh +++ b/scripts/engine.sh @@ -612,7 +612,7 @@ _mcp_review_flags() { local base="$1" _MCP_FLAGS=() _MCP_ALLOWED_TOOLS="$base" - if [ -n "${REVIEW_MCP_CONFIG:-}" ] && [ -r "${REVIEW_MCP_CONFIG}" ]; then + if [ -n "${REVIEW_MCP_CONFIG:-}" ] && [ -f "${REVIEW_MCP_CONFIG}" ] && [ -r "${REVIEW_MCP_CONFIG}" ]; then _MCP_FLAGS=(--mcp-config "$REVIEW_MCP_CONFIG" --strict-mcp-config) if [ -n "${REVIEW_MCP_ALLOWED_TOOLS:-}" ]; then _MCP_ALLOWED_TOOLS="${base},${REVIEW_MCP_ALLOWED_TOOLS}" @@ -752,13 +752,13 @@ run_agentic() { _claude_chain_invoke "$_agentic_chain" "$prompt_file" "$DEEP_TIMEOUT_SEC" \ --permission-mode acceptEdits \ --allowed-tools "$_MCP_ALLOWED_TOOLS" \ - "${_MCP_FLAGS[@]}" \ + ${_MCP_FLAGS[@]+"${_MCP_FLAGS[@]}"} \ | tee "$_tok_tmp" || rc=${PIPESTATUS[0]} else _claude_chain_invoke "$_agentic_chain" "$prompt_file" "$DEEP_TIMEOUT_SEC" \ --permission-mode acceptEdits \ --allowed-tools "$_MCP_ALLOWED_TOOLS" \ - "${_MCP_FLAGS[@]}" \ + ${_MCP_FLAGS[@]+"${_MCP_FLAGS[@]}"} \ || rc=$? fi ;; @@ -861,14 +861,14 @@ run_duck() { --permission-mode acceptEdits \ --allowed-tools "$_MCP_ALLOWED_TOOLS" \ --max-turns 25 \ - "${_MCP_FLAGS[@]}" \ + ${_MCP_FLAGS[@]+"${_MCP_FLAGS[@]}"} \ | tee "$_tok_tmp" || rc=${PIPESTATUS[0]} else _claude_chain_invoke "$model" "$prompt_file" "$DUCK_TIMEOUT_SEC" \ --permission-mode acceptEdits \ --allowed-tools "$_MCP_ALLOWED_TOOLS" \ --max-turns 25 \ - "${_MCP_FLAGS[@]}" \ + ${_MCP_FLAGS[@]+"${_MCP_FLAGS[@]}"} \ || rc=$? fi ;; diff --git a/tests/dev-lead/unit/test_engine_mcp.bats b/tests/dev-lead/unit/test_engine_mcp.bats index b587d9431..1917098b7 100644 --- a/tests/dev-lead/unit/test_engine_mcp.bats +++ b/tests/dev-lead/unit/test_engine_mcp.bats @@ -83,6 +83,16 @@ _source_engine() { grep -q -- "--allowed-tools Bash,Read,Grep,Glob" "$ARGS_RECORD" } +@test "agentic: REVIEW_MCP_CONFIG pointing to a directory → no MCP flags" { + _source_engine "claude" + export REVIEW_MCP_CONFIG="$(mktemp -d)" + run run_agentic "$TEST_PROMPT" "claude-opus-4-8" "deep" + rmdir "$REVIEW_MCP_CONFIG" + [ "$status" -eq 0 ] + ! grep -q -- "--mcp-config" "$ARGS_RECORD" + grep -q -- "--allowed-tools Bash,Read,Grep,Glob" "$ARGS_RECORD" +} + # ── Knob set: MCP flags threaded into agentic ──────────────────────────────── @test "agentic: REVIEW_MCP_CONFIG set → MCP flags appended to claude call" { From 0740429f99549e4a9425f073e04ce325f856df74 Mon Sep 17 00:00:00 2001 From: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com> Date: Sun, 14 Jun 2026 13:33:58 +0000 Subject: [PATCH 3/3] fix(reviews): address review comments [skip ci-relay] --- tests/dev-lead/unit/test_engine_chain.bats | 2 +- tests/dev-lead/unit/test_engine_fallback.bats | 2 +- tests/dev-lead/unit/test_engine_mcp.bats | 9 +++++++-- tests/dev-lead/unit/test_engine_new_models.bats | 2 +- tests/dev-lead/unit/test_engine_writer.bats | 2 +- tests/dev-lead/unit/test_model_dispatch.bats | 2 +- tests/dev-lead/unit/test_provider_headroom.bats | 2 +- 7 files changed, 13 insertions(+), 8 deletions(-) diff --git a/tests/dev-lead/unit/test_engine_chain.bats b/tests/dev-lead/unit/test_engine_chain.bats index c1c066e09..ccf799fa1 100644 --- a/tests/dev-lead/unit/test_engine_chain.bats +++ b/tests/dev-lead/unit/test_engine_chain.bats @@ -47,7 +47,7 @@ teardown() { _source_engine() { local engine="${1:-claude}" export REVIEW_ENGINE="$engine" - source "$ENGINE_SCRIPT" 2>/dev/null || true + source "$ENGINE_SCRIPT" } # ── _claude_chain_invoke unit tests ─────────────────────────────────────────── diff --git a/tests/dev-lead/unit/test_engine_fallback.bats b/tests/dev-lead/unit/test_engine_fallback.bats index 777e144a2..7ace2f203 100644 --- a/tests/dev-lead/unit/test_engine_fallback.bats +++ b/tests/dev-lead/unit/test_engine_fallback.bats @@ -34,7 +34,7 @@ teardown() { _source_engine() { local engine="${1:-claude}" export REVIEW_ENGINE="$engine" - source "$ENGINE_SCRIPT" 2>/dev/null || true + source "$ENGINE_SCRIPT" } # Helper: create a stub that always returns a given exit code diff --git a/tests/dev-lead/unit/test_engine_mcp.bats b/tests/dev-lead/unit/test_engine_mcp.bats index 1917098b7..ca971f22c 100644 --- a/tests/dev-lead/unit/test_engine_mcp.bats +++ b/tests/dev-lead/unit/test_engine_mcp.bats @@ -52,7 +52,7 @@ teardown() { _source_engine() { local engine="${1:-claude}" export REVIEW_ENGINE="$engine" - source "$ENGINE_SCRIPT" 2>/dev/null || true + source "$ENGINE_SCRIPT" } # ── Default (knob unset): behavior unchanged ────────────────────────────────── @@ -76,8 +76,13 @@ _source_engine() { @test "agentic: REVIEW_MCP_CONFIG pointing to unreadable file → no MCP flags" { _source_engine "claude" - export REVIEW_MCP_CONFIG="/nonexistent/path/mcp-does-not-exist.json" + local unreadable_file + unreadable_file="$(mktemp)" + chmod 000 "$unreadable_file" + export REVIEW_MCP_CONFIG="$unreadable_file" run run_agentic "$TEST_PROMPT" "claude-opus-4-8" "deep" + chmod 600 "$unreadable_file" + rm -f "$unreadable_file" [ "$status" -eq 0 ] ! grep -q -- "--mcp-config" "$ARGS_RECORD" grep -q -- "--allowed-tools Bash,Read,Grep,Glob" "$ARGS_RECORD" diff --git a/tests/dev-lead/unit/test_engine_new_models.bats b/tests/dev-lead/unit/test_engine_new_models.bats index 7a88fdf96..6370e151a 100644 --- a/tests/dev-lead/unit/test_engine_new_models.bats +++ b/tests/dev-lead/unit/test_engine_new_models.bats @@ -51,7 +51,7 @@ teardown() { _source_engine() { local engine="${1:-claude}" export REVIEW_ENGINE="$engine" - source "$ENGINE_SCRIPT" 2>/dev/null || true + source "$ENGINE_SCRIPT" } # ── Tier default model assignments ─────────────────────────────────────────── diff --git a/tests/dev-lead/unit/test_engine_writer.bats b/tests/dev-lead/unit/test_engine_writer.bats index 816f7d938..f5127bb66 100644 --- a/tests/dev-lead/unit/test_engine_writer.bats +++ b/tests/dev-lead/unit/test_engine_writer.bats @@ -35,7 +35,7 @@ teardown() { _source_engine() { local engine="${1:-claude}" export REVIEW_ENGINE="$engine" - source "$ENGINE_SCRIPT" 2>/dev/null || true + source "$ENGINE_SCRIPT" } # ── run_writer tests ────────────────────────────────────────────────────────── diff --git a/tests/dev-lead/unit/test_model_dispatch.bats b/tests/dev-lead/unit/test_model_dispatch.bats index f8cba6d3d..aa5439d31 100644 --- a/tests/dev-lead/unit/test_model_dispatch.bats +++ b/tests/dev-lead/unit/test_model_dispatch.bats @@ -16,7 +16,7 @@ teardown() { _source_engine() { local engine="${1:-claude}" export REVIEW_ENGINE="$engine" - source "$ENGINE_SCRIPT" 2>/dev/null || true + source "$ENGINE_SCRIPT" } # ── triage-tier intents (haiku / lightest model) ────────────────────────────── diff --git a/tests/dev-lead/unit/test_provider_headroom.bats b/tests/dev-lead/unit/test_provider_headroom.bats index 4a0943044..a07565a83 100644 --- a/tests/dev-lead/unit/test_provider_headroom.bats +++ b/tests/dev-lead/unit/test_provider_headroom.bats @@ -20,7 +20,7 @@ teardown() { _source_engine() { local engine="${1:-claude}" export REVIEW_ENGINE="$engine" - source "$ENGINE_SCRIPT" 2>/dev/null || true + source "$ENGINE_SCRIPT" } # Helper: install a curl stub that outputs given headers and exits with given code