From 6404b2f88b0e4f25867a9020999ea3d18a585a7d Mon Sep 17 00:00:00 2001 From: Don Petry <36422719+don-petry@users.noreply.github.com> Date: Tue, 19 May 2026 23:18:35 -0500 Subject: [PATCH 1/2] fix(pr-review): route check_suite events to per-PR concurrency slot MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit check_suite events were falling through to pr-review-batch regardless of whether they had an associated PR. When multiple PRs' CI suites complete simultaneously, they competed for the same batch slot — the GitHub Actions concurrency model keeps only one queued run per group, so all but the last winner were cancelled. Add github.event.check_suite.pull_requests[0].html_url to the concurrency group expression so per-PR check_suite events use the pr-review-pr-{url} slot instead of pr-review-batch. Same-PR cancellations are safe (idempotent on the same head SHA); cross-PR cancellations are now eliminated. Main-branch check_suite events (no pull_requests) still fall through to pr-review-batch unchanged. --- .github/workflows/pr-review.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-review.yml b/.github/workflows/pr-review.yml index 372611aa4..5091472d9 100644 --- a/.github/workflows/pr-review.yml +++ b/.github/workflows/pr-review.yml @@ -67,16 +67,22 @@ permissions: concurrency: # Event-triggered and mention-triggered runs for a specific PR get a per-PR # concurrency slot so they never queue behind unrelated PRs. + # check_suite events carry the associated PR in pull_requests[0]; including + # that URL here prevents cross-PR cancellation when multiple PRs' CI suites + # complete simultaneously (each PR competes only with itself, which is safe + # since same-PR runs are idempotent on the same head SHA). # Manual batch runs (workflow_dispatch without pr_url) use a shared slot. group: >- ${{ (inputs.pr_url || github.event.client_payload.pr_url - || github.event.pull_request.html_url) + || github.event.pull_request.html_url + || github.event.check_suite.pull_requests[0].html_url) && format('pr-review-pr-{0}', inputs.pr_url || github.event.client_payload.pr_url - || github.event.pull_request.html_url) + || github.event.pull_request.html_url + || github.event.check_suite.pull_requests[0].html_url) || 'pr-review-batch' }} cancel-in-progress: false From d740d7333c29afd98a857c8b5b4ec73c65c88b13 Mon Sep 17 00:00:00 2001 From: donpetry-bot Date: Wed, 20 May 2026 11:53:19 +0000 Subject: [PATCH 2/2] fix(reviews): address review comments [skip ci-relay] --- .github/workflows/pr-review.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-review.yml b/.github/workflows/pr-review.yml index 9a604849b..6fa237dc2 100644 --- a/.github/workflows/pr-review.yml +++ b/.github/workflows/pr-review.yml @@ -71,18 +71,20 @@ concurrency: # that URL here prevents cross-PR cancellation when multiple PRs' CI suites # complete simultaneously (each PR competes only with itself, which is safe # since same-PR runs are idempotent on the same head SHA). + # Note: check_suite.pull_requests entries expose the API `url` field, not + # `html_url` — using `url` here matches the payload shape. # Manual batch runs (workflow_dispatch without pr_url) use a shared slot. group: >- ${{ (inputs.pr_url || github.event.client_payload.pr_url || github.event.pull_request.html_url - || github.event.check_suite.pull_requests[0].html_url) + || github.event.check_suite.pull_requests[0].url) && format('pr-review-pr-{0}', inputs.pr_url || github.event.client_payload.pr_url || github.event.pull_request.html_url - || github.event.check_suite.pull_requests[0].html_url) + || github.event.check_suite.pull_requests[0].url) || 'pr-review-batch' }} cancel-in-progress: false