Skip to content

feat(todo|allure): Add method todo for planning on writing tests - #2100

Merged
DavertMik merged 8 commits into
codeceptjs:masterfrom
Tinkoff:add-skip-message
Jan 8, 2020
Merged

DavertMik merged 8 commits into
codeceptjs:masterfrom
Tinkoff:add-skip-message

Conversation

@Vorobeyko

@Vorobeyko Vorobeyko commented Dec 23, 2019 •

Copy link
Copy Markdown
Contributor

Motivation/Description of the PR

Applicable helpers:

  • Webdriver

  • Puppeteer

  • Nightmare

  • REST

  • Appium

  • Protractor

  • TestCafe

  • Description of this PR, which problem it solves

  • A link to the corresponding issue (if applicable).

Type of change

  • Breaking changes
  • New functionality
  • Bug fix
  • Documentation changes/updates
  • Hot fix
  • Markdown files fix - not related to source code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

Comment thread docs/basics.md Outdated
Comment thread docs/plugins.md Outdated
Comment thread lib/ui.js Outdated
Comment thread lib/ui.js
@Vorobeyko Vorobeyko changed the title feat(skip|allure): Add ability to pass skip message for Scenario feat(todo|allure): Add method todo for planning on writing tests Dec 24, 2019
@Vorobeyko

Copy link
Copy Markdown
Contributor Author

Need add docs to https://codecept.io/hooks/#api

@DavertMik DavertMik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests needed. But I like how it looks overall

@DavertMik

Copy link
Copy Markdown
Contributor

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- test/data/sandbox/configs/todo/first_test.js  3
- test/runner/todo_test.js  1
         

See the complete overview on Codacy

Comment thread lib/plugin/allure.js
@kobenguyent

Copy link
Copy Markdown
Collaborator

@Vorobeyko just curious how this will be displayed when using dry-run. Other than that I have nothing more.

@Vorobeyko

Copy link
Copy Markdown
Contributor Author

@Vorobeyko just curious how this will be displayed when using dry-run. Other than that I have nothing more.

Like skipped test)

@DavertMik

Copy link
Copy Markdown
Contributor

Nice. Let's have this!

@DavertMik
DavertMik merged commit 6bde311 into codeceptjs:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants