Skip to content

feat(perf): support JMH benchmark in HG-test module - #2238

Merged
imbajin merged 6 commits into
apache:masterfrom
conghuhu:cgq
Jul 17, 2023
Merged

imbajin merged 6 commits into
apache:masterfrom
conghuhu:cgq

Conversation

@conghuhu

@conghuhu conghuhu commented Jul 4, 2023 •

Copy link
Copy Markdown
Contributor

Purpose of the PR

  • We currently miss a benchmark to compare some performance components, such as concurrent map.
  • I have added a simple example to compare the random read and write performance between IntMapBySegments and ConcurrentHashMap

Result as follows, the performance of IntMapBySegments is very good:

image

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@conghuhu

conghuhu commented Jul 4, 2023 •

Copy link
Copy Markdown
Contributor Author

@imbajin @javeme PTAL

@codecov

codecov Bot commented Jul 4, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #2238 (b93289c) into master (8ee3d32) will decrease coverage by 7.35%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master    #2238      +/-   ##
============================================
- Coverage     65.03%   57.69%   -7.35%     
+ Complexity      979      657     -322     
============================================
  Files           498      498              
  Lines         40682    40684       +2     
  Branches       5681     5681              
============================================
- Hits          26458    23472    -2986     
- Misses        11596    14781    +3185     
+ Partials       2628     2431     -197     
Impacted Files Coverage Δ
...a/org/apache/hugegraph/util/collection/IntMap.java 45.63% <33.33%> (-26.77%) ⬇️

... and 107 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@simon824

simon824 commented Jul 5, 2023

Copy link
Copy Markdown
Member

We need check and add license files when adding 3rd-party dependencies, refer to document.

Comment thread hugegraph-dist/release-docs/LICENSE Resolved
@conghuhu
conghuhu requested a review from javeme July 6, 2023 01:23
@imbajin imbajin changed the title feat: add benchmark in hg-test & add jmh feat(perf): support JMH benchmark in HG-test module Jul 9, 2023
@imbajin imbajin added feature New feature dependencies Incompatible dependencies of package perf labels Jul 9, 2023
Comment thread pom.xml Resolved

@javeme javeme left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imbajin
imbajin merged commit 5df28fa into apache:master Jul 17, 2023
@imbajin

imbajin commented Jul 17, 2023

Copy link
Copy Markdown
Member

@conghuhu could also open a summary issue for this task, and link this PR as the subtask 🔢

and also could update the doc to link the summary issue

@imbajin

imbajin commented Jul 17, 2023

Copy link
Copy Markdown
Member

Another CI error TODO alert:

image

@conghuhu could u help to fix it when free~

@conghuhu
conghuhu deleted the cgq branch July 17, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Incompatible dependencies of package feature New feature perf

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants