Repository navigation
fix(v2): decouple session updates from prompt completion - #280
Merged
Merged
Conversation
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ACP v2 prompt responses acknowledge insertion of a user message, while
state_updatereports session-scoped foreground work. The SDK previously treated any idle update as completion of all pending prompts, even if a prompt had not been inserted yet.stopmessage, independent of prompt requests.readText()withreadTextUntilIdle()to make its session-scoped collection boundary explicit.Experimental v2 API migration
Replace
session.readText()withsession.readTextUntilIdle(). The new helper consumes queued session output until the next idle notification. It does not attribute that output to a particular prompt, skip earlier updates, or guarantee that a submitted message has been processed. Use one reader at a time.session.prompt()still returns the insertion receipt andmessageId. Handle request rejection through that promise; session readers continue independently.V1 and the protocol wire schema are unchanged. No prompt or turn correlation fields are added to
state_update.Validation
npm run checkpassed: generated-source checks, lint, formatting, spelling, TypeScript build, full test suite, and TypeDoc verification.git diff --checkpassed.