From c70558bde56a3d9b3f99711f5eb7e8dd39a1bfb1 Mon Sep 17 00:00:00 2001 From: Teodor Taushanov Date: Mon, 2 Nov 2026 15:29:03 +0200 Subject: [PATCH] fix(ui5-side-navigation): remove aria-roledescription from navigation lists Remove the aria-roledescription attribute from the flexible and fixed navigation lists, along with the related getter and i18n keys, and adapt the affected test accordingly. --- packages/fiori/cypress/specs/SideNavigation.cy.tsx | 2 +- packages/fiori/src/SideNavigation.ts | 11 ----------- packages/fiori/src/SideNavigationTemplate.tsx | 4 ---- packages/fiori/src/i18n/messagebundle.properties | 6 ------ 4 files changed, 1 insertion(+), 22 deletions(-) diff --git a/packages/fiori/cypress/specs/SideNavigation.cy.tsx b/packages/fiori/cypress/specs/SideNavigation.cy.tsx index 22ce1568af4f9..92d8a11ea0a6e 100644 --- a/packages/fiori/cypress/specs/SideNavigation.cy.tsx +++ b/packages/fiori/cypress/specs/SideNavigation.cy.tsx @@ -1507,7 +1507,7 @@ describe("Side Navigation Accessibility", () => { cy.get("#sideNav") .shadow() .find(".ui5-sn-flexible") - .should("have.attr", "aria-roledescription", "Navigation List Menu Bar"); + .should("not.have.attr", "aria-roledescription"); cy.get("#sideNav") .invoke("attr", "style", "height: 100px"); diff --git a/packages/fiori/src/SideNavigation.ts b/packages/fiori/src/SideNavigation.ts index dbdaca817c756..444248f33f298 100644 --- a/packages/fiori/src/SideNavigation.ts +++ b/packages/fiori/src/SideNavigation.ts @@ -32,8 +32,6 @@ import SideNavigationTemplate from "./SideNavigationTemplate.js"; import { SIDE_NAVIGATION_POPOVER_HIDDEN_TEXT, - SIDE_NAVIGATION_COLLAPSED_LIST_ARIA_ROLE_DESC, - SIDE_NAVIGATION_LIST_ARIA_ROLE_DESC, SIDE_NAVIGATION_OVERFLOW_ACCESSIBLE_NAME, SIDE_NAVIGATION_FLEXIBLE_LIST_LABEL, SIDE_NAVIGATION_FIXED_LIST_LABEL, @@ -382,15 +380,6 @@ class SideNavigation extends UI5Element { return SideNavigation.i18nBundle.getText(SIDE_NAVIGATION_POPOVER_HIDDEN_TEXT); } - get ariaRoleDescNavigationList() { - let key = SIDE_NAVIGATION_LIST_ARIA_ROLE_DESC; - if (this.collapsed) { - key = SIDE_NAVIGATION_COLLAPSED_LIST_ARIA_ROLE_DESC; - } - - return SideNavigation.i18nBundle.getText(key); - } - get navigationMenuPrimaryHiddenText() { return SideNavigation.i18nBundle.getText(SIDE_NAVIGATION_FLEXIBLE_LIST_LABEL); } diff --git a/packages/fiori/src/SideNavigationTemplate.tsx b/packages/fiori/src/SideNavigationTemplate.tsx index f9786aa793a7f..73f23f4f5f6b6 100644 --- a/packages/fiori/src/SideNavigationTemplate.tsx +++ b/packages/fiori/src/SideNavigationTemplate.tsx @@ -20,7 +20,6 @@ export default function SideNavigationTemplate(this: SideNavigation) {