Skip to content

fix(ui5-rating-indicator): rename maxValue property to max - #3375

Merged
fifoosid merged 2 commits into
masterfrom
ratiing-indicator-max
Jun 9, 2021
Merged

fifoosid merged 2 commits into
masterfrom
ratiing-indicator-max

Conversation

@fifoosid

@fifoosid fifoosid commented Jun 2, 2021

Copy link
Copy Markdown
Contributor

Part of #3107

BREAKING_CHANGE: maxValue property of ui5-rating-indicator is deprecated in favour of max property.

@fifoosid fifoosid mentioned this pull request Jun 2, 2021
@ilhan007

ilhan007 commented Jun 7, 2021 •

Copy link
Copy Markdown
Contributor

Hello @SAP/ui5-webcomponents-topic-rl this si a change in the name of the maxValue property to max as part of the Components API Review that is currently in progress.
The change is for the sake of consistency as we have min and max in other components such as StepInput, (Range)Slider. Do you think this is appropriate? If you have any concerns or suggestions, please share them with us.

@fifoosid
fifoosid merged commit 8aaf99b into master Jun 9, 2021
@fifoosid
fifoosid deleted the ratiing-indicator-max branch June 9, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants