Skip to content

fix(ui5-messagestrip): rename properties - #3346

Merged
ilhan007 merged 2 commits into
masterfrom
messagestrip-no
May 28, 2021
Merged

ilhan007 merged 2 commits into
masterfrom
messagestrip-no

Conversation

@fifoosid

@fifoosid fifoosid commented May 28, 2021 •

Copy link
Copy Markdown
Contributor

Part of #3107

BREAKING_CHANGE: rename noIcon property to hideIcon
BREAKING_CHANGE: rename noCloseButton property to hideCloseButton

@ilhan007

Copy link
Copy Markdown
Contributor

Some merge conflicts otherwise +1

@fifoosid fifoosid mentioned this pull request May 28, 2021
@ilhan007

Copy link
Copy Markdown
Contributor

good to go

@ilhan007
ilhan007 merged commit 1cb43f2 into master May 28, 2021
@ilhan007
ilhan007 deleted the messagestrip-no branch May 28, 2021 13:53
kskondov pushed a commit that referenced this pull request May 31, 2021
Part of #3107

BREAKING_CHANGE: The property `noIcon`  has been renamed to `hideIcon`
BREAKING_CHANGE: The property `noCloseButton` has been renamed to `hideCloseButton`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants