Repository navigation
fix(list items): rename info & infoState properties - #3259
Merged
Merged
Conversation
Closed
nnaydenow
reviewed
May 18, 2021
nnaydenow
left a comment
nnaydenow
left a comment
Contributor
There was a problem hiding this comment.
At all it looks okey for me. We can add someone from @SAP/ui5-webcomponents-topic-rl to approve the changes in input files
| {{#if info}} | ||
| <span part="info" class="ui5-li-info">{{info}}</span> | ||
| {{#if additionalText}} | ||
| <span part="additionalText" class="ui5-li-info">{{additionalText}}</span> |
Contributor
There was a problem hiding this comment.
I'm not familiar with part but should we keep its value in camelCase style?
Contributor
There was a problem hiding this comment.
@nnaydenow we decided to write the CSS Shadow Parts in kebab-case
Contributor
ilhan007
approved these changes
May 19, 2021
ilhan007
reviewed
May 19, 2021
ilhan007
reviewed
May 19, 2021
ilhan007
requested changes
May 19, 2021
ilhan007
left a comment
ilhan007
left a comment
Contributor
There was a problem hiding this comment.
Check some css class naming in relation to the prop name change, described inline
Contributor
|
For me it looks okey now. |
ilhan007
approved these changes
May 28, 2021
kskondov
pushed a commit
that referenced
this pull request
May 31, 2021
Part of #3107 BREAKING_CHANGE: ```info``` and ```infoState``` properties of ```StandardListItem``` have been deprecated in favour of ```additionalText``` and ```AdditionalTextState``` properties BREAKING_CHANGE: ```info``` and ```infoState``` properties of ```SuggestionItem``` have been deprecated in favour of ```additionalText``` and ```AdditionalTextState``` properties BREAKING_CHANGE: ```info``` and ```infoState``` properties of ```TreeItem``` have been deprecated in favour of ```additionalText``` and ```AdditionalTextState``` properties BREAKING_CHANGE: ```info``` and ```infoState``` properties of ```TreeListItem``` have been deprecated in favour of ```additionalText``` and ```AdditionalTextState``` properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3107
BREAKING_CHANGE:
infoandinfoStateproperties ofStandardListItemhave been deprecated in favour ofadditionalTextandAdditionalTextStatepropertiesBREAKING_CHANGE:
infoandinfoStateproperties ofSuggestionItemhave been deprecated in favour ofadditionalTextandAdditionalTextStatepropertiesBREAKING_CHANGE:
infoandinfoStateproperties ofTreeItemhave been deprecated in favour ofadditionalTextandAdditionalTextStatepropertiesBREAKING_CHANGE:
infoandinfoStateproperties ofTreeListItemhave been deprecated in favour ofadditionalTextandAdditionalTextStateproperties