Repository navigation
feat(ui5-switch): implement design property - #3257
Merged
Merged
Conversation
Closed
ilhan007
previously approved these changes
May 27, 2021
Contributor
|
@fifoosid Some merge conflict should be resolved, then you can merge it. |
ilhan007
approved these changes
May 28, 2021
ilhan007
requested review from
a team and
tsanislavgatev
and removed request for
dobrinyonkov and
nnaydenow
May 28, 2021 14:10
kskondov
pushed a commit
that referenced
this pull request
May 31, 2021
Part of #3107. To keep the door open for new predefined designs in future, we decided to change the boolean property to enum as more flexible solution. BREAKING_CHANGE: Deprecate graphical property in favour of design prope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3107. To keep the door open for new predefined designs in future, we decided to change the boolean property to enum as more flexible solution.
BREAKING_CHANGE: Deprecate
graphicalproperty in favour ofdesignproperty