Repository navigation
feat(ui5-avatar): implement default slot - #3237
Merged
Merged
Conversation
Closed
dobrinyonkov
left a comment
dobrinyonkov
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. I just found 2 more uses of the image property:
- AvatarGroup.sample.html
- AvatarGroup.html
ilhan007
approved these changes
Jul 15, 2021
Contributor
There was a problem hiding this comment.
+1 ok to me, @SAP/ui5-webcomponents-topic-p @nnaydenow @dobrinyonkov could you make the final review
nnaydenow
approved these changes
Jul 15, 2021
kineticjs
pushed a commit
to kineticjs/ui5-webcomponents
that referenced
this pull request
Jul 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3107
BREAKING_CHANGE:
imageandimageFitTypeproperties are now deprecated in favour of default slot