a bunch more tests and a bug fix

had to clear path_prefix from api scope. It needs a unique combination with host, so we can't just duplicate them verbatim.

Author: jtmkrueger

src/api-umbrella/admin-ui/app/models/api-scope.js

@@ -35,6 +35,7 @@ class ApiScope extends Model.extend(Validations) {
   static urlRoot = '/api-umbrella/v1/api_scopes';
   static singlePayloadKey = 'api_scope';
   static arrayPayloadKey = 'data';
+  static duplicateExclude = ['pathPrefix'];
 
   @attr()
   name;

test/admin_ui/test_admin_groups.rb

@@ -104,4 +104,11 @@ def test_duplicate_creates_new_record_with_copied_data
     assert_equal("Source Group For Duplicate", source.name, "source name unchanged")
     assert_equal(source_api_scope_ids, source.api_scope_ids.sort, "source scopes unchanged")
   end
+
+  def test_duplicate_link_hidden_on_new_form
+    admin_login
+    visit "/admin/#/admin_groups/new"
+    assert_field("Group Name")
+    refute_selector("a.duplicate-action")
+  end
 end

test/admin_ui/test_admins.rb

@@ -99,4 +99,45 @@ def test_non_admin_manager_views_own_profile
     assert_text(admin.authentication_token)
     refute_button("Save")
   end
+
+  def test_duplicate_creates_new_record_with_email_cleared
+    group = FactoryBot.create(:admin_group, :name => "Group For Duplicate")
+    source = FactoryBot.create(:limited_admin, :username => "source.admin@example.com", :groups => [group])
+    source_id = source.id
+    source_username = source.username
+    source_email = source.email
+    source_group_ids = source.group_ids.sort
+
+    admin_login
+    visit "/admin/#/admins/#{source.id}/edit"
+    assert_field("Email", :with => "source.admin@example.com")
+
+    find("a.duplicate-action", :text => /Duplicate Admin/).click
+
+    assert_current_path %r{/admin/#/admins/new\?duplicate_id=#{source.id}}, :url => true
+    assert_text("Duplicated from")
+    assert_field("Email", :with => "")
+
+    fill_in("Email", :with => "duplicate.admin@example.com")
+    click_button("Save")
+    assert_text("Successfully saved the admin")
+
+    duplicate = Admin.where(:username => "duplicate.admin@example.com").order(:created_at => :desc).first
+    refute_nil(duplicate, "duplicate admin was created")
+    refute_equal(source_id, duplicate.id, "duplicate has fresh id")
+    refute_equal(source_username, duplicate.username, "duplicate has fresh username")
+    refute_equal(source_email, duplicate.email, "duplicate has fresh email")
+    assert_equal(source_group_ids, duplicate.group_ids.sort, "duplicate references same groups as source")
+
+    source.reload
+    assert_equal(source_username, source.username, "source username unchanged")
+    assert_equal(source_email, source.email, "source email unchanged")
+  end
+
+  def test_duplicate_link_hidden_on_new_form
+    admin_login
+    visit "/admin/#/admins/new"
+    assert_text("Email")
+    refute_selector("a.duplicate-action")
+  end
 end

test/admin_ui/test_api_scopes.rb

@@ -49,4 +49,45 @@ def test_update
     assert_equal("2.example.com", api_scope.host)
     assert_equal("/2/", api_scope.path_prefix)
   end
+
+  def test_duplicate_creates_new_record_with_path_prefix_cleared
+    source = FactoryBot.create(:api_scope, :name => "Source Scope For Duplicate", :host => "source.example.com", :path_prefix => "/source/")
+    source_id = source.id
+    source_host = source.host
+    source_path_prefix = source.path_prefix
+
+    admin_login
+    visit "/admin/#/api_scopes/#{source.id}/edit"
+    assert_field("Name", :with => "Source Scope For Duplicate")
+
+    find("a.duplicate-action", :text => /Duplicate API Scope/).click
+
+    assert_current_path %r{/admin/#/api_scopes/new\?duplicate_id=#{source.id}}, :url => true
+    assert_text("Duplicated from Source Scope For Duplicate")
+    assert_field("Name", :with => "Source Scope For Duplicate")
+    assert_field("Host", :with => "source.example.com")
+    assert_field("Path Prefix", :with => "")
+
+    fill_in("Name", :with => "Duplicate Scope For Duplicate")
+    fill_in("Path Prefix", :with => "/duplicate/")
+    click_button("Save")
+    assert_text("Successfully saved")
+
+    duplicate = ApiScope.where(:name => "Duplicate Scope For Duplicate").order(:created_at => :desc).first
+    refute_nil(duplicate, "duplicate scope was created")
+    refute_equal(source_id, duplicate.id, "duplicate has fresh id")
+    assert_equal(source_host, duplicate.host, "host preserved")
+    assert_equal("/duplicate/", duplicate.path_prefix, "duplicate has new path_prefix")
+
+    source.reload
+    assert_equal("Source Scope For Duplicate", source.name, "source name unchanged")
+    assert_equal(source_path_prefix, source.path_prefix, "source path_prefix unchanged")
+  end
+
+  def test_duplicate_link_hidden_on_new_form
+    admin_login
+    visit "/admin/#/api_scopes/new"
+    assert_field("Name")
+    refute_selector("a.duplicate-action")
+  end
 end

test/admin_ui/test_api_users.rb

@@ -127,4 +127,11 @@ def test_duplicate_creates_new_record_with_email_cleared
     assert_equal(source_email, source.email, "source email unchanged")
     assert_equal(source_api_key, source.api_key, "source api_key unchanged")
   end
+
+  def test_duplicate_link_hidden_on_new_form
+    admin_login
+    visit "/admin/#/api_users/new"
+    assert_field("E-mail")
+    refute_selector("a.duplicate-action")
+  end
 end

test/admin_ui/test_apis.rb

@@ -499,4 +499,11 @@ def test_duplicate_creates_new_record_with_copied_data
     assert_equal("Source Backend Test", source.name, "source name unchanged")
     assert_equal(source_server_ids.sort, source.servers.map(&:id).sort, "source servers unchanged")
   end
+
+  def test_duplicate_link_hidden_on_new_form
+    admin_login
+    visit "/admin/#/apis/new"
+    assert_field("Name")
+    refute_selector("a.duplicate-action")
+  end
 end

test/admin_ui/test_website_backends.rb

@@ -0,0 +1,52 @@
+require_relative "../test_helper"
+
+class Test::AdminUi::TestWebsiteBackends < Minitest::Capybara::Test
+  include Capybara::Screenshot::MiniTestPlugin
+  include ApiUmbrellaTestHelpers::AdminAuth
+  include ApiUmbrellaTestHelpers::Setup
+
+  def setup
+    super
+    setup_server
+  end
+
+  def test_duplicate_creates_new_record_with_copied_data
+    source = FactoryBot.create(:website_backend, :frontend_host => "source.example.com", :server_host => "backend.example.com", :server_port => 8080)
+    source_id = source.id
+    source_frontend_host = source.frontend_host
+    source_server_host = source.server_host
+    source_server_port = source.server_port
+
+    admin_login
+    visit "/admin/#/website_backends/#{source.id}/edit"
+    assert_field("Frontend Host", :with => "source.example.com")
+
+    find("a.duplicate-action", :text => /Duplicate Website Backend/).click
+
+    assert_current_path %r{/admin/#/website_backends/new\?duplicate_id=#{source.id}}, :url => true
+    assert_text("Duplicated from")
+    assert_field("Frontend Host", :with => "source.example.com")
+    assert_field("Backend Server", :with => "backend.example.com")
+    assert_field("Backend Port", :with => "8080")
+
+    fill_in("Frontend Host", :with => "duplicate.example.com")
+    click_button("Save")
+    assert_text("Successfully saved")
+
+    duplicate = WebsiteBackend.where(:frontend_host => "duplicate.example.com").order(:created_at => :desc).first
+    refute_nil(duplicate, "duplicate website-backend was created")
+    refute_equal(source_id, duplicate.id, "duplicate has fresh id")
+    assert_equal(source_server_host, duplicate.server_host, "server_host preserved")
+    assert_equal(source_server_port, duplicate.server_port, "server_port preserved")
+
+    source.reload
+    assert_equal(source_frontend_host, source.frontend_host, "source frontend_host unchanged")
+  end
+
+  def test_duplicate_link_hidden_on_new_form
+    admin_login
+    visit "/admin/#/website_backends/new"
+    assert_field("Frontend Host")
+    refute_selector("a.duplicate-action")
+  end
+end