Add an AUC Units parameter for the PSTH peak and area - #415
Merged
Conversation
The area under the curve was integrated with one-sample spacing, so it was reported in z-score * samples and scaled with the recording's sampling rate. The new "AUC Units" selector adds a "seconds" option that integrates against the PSTH time axis, giving z-score * seconds. The default keeps the existing sample-spacing behavior. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
pauladkisson
enabled auto-merge
August 6, 2026 23:45
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #366
Details (AI-generated)
Closes #366.
Adds an AUC Units selector to the Peak and AUC Parameters box.
secondsintegrates each peak window against the PSTH time axis, soarea_*is reported in z-score (or ΔF/F) × seconds;sampleskeeps the existing one-sample spacing and remains the default. The setting is recorded inGuPPyParamtersUsed.jsonand exposed asstep4(auc_units=...)in the testing API. Thearea_*column names are unchanged, so nothing downstream ofpeak_AUC_*moves.Verification:
tests/unit/analysis/test_psth_peak_and_area.py,tests/unit/orchestration/,tests/unit/frontend/test_input_parameters.py,tests/unit/testing/,tests/integration/test_integration_step4.py,test_integration_home.py,test_integration_save_parameters.py— 216 passed.pre-commitclean. The default path is unchanged, so the consistency baselines are untouched.🤖 Generated with Claude Code