Fixed ruff

Author: dineshbaburam91

lib/jnpr/junos/facts/get_jnu_satellites_information.py

@@ -22,18 +22,14 @@ def provides_facts():
 
 def _get_sat_dev(rsp, name):
     """Return the <satellite-device> element matching *name*, or first found."""
-    sat_dev = rsp.find(
-        ".//satellite-device[satellite-mgmt-ip='{}']".format(name)
-    )
+    sat_dev = rsp.find(".//satellite-device[satellite-mgmt-ip='{}']".format(name))
     return sat_dev if sat_dev is not None else rsp.find(".//satellite-device")
 
 
 def _collect_sw_facts(device, name, sat_facts):
     """Populate software version facts from get_software_information."""
     try:
-        rsp = device.rpc.get_software_information(
-            device_list=name, normalize=True
-        )
+        rsp = device.rpc.get_software_information(device_list=name, normalize=True)
         if rsp is None or rsp is True:
             return
         sat_dev = _get_sat_dev(rsp, name)
@@ -53,9 +49,7 @@ def _collect_sw_facts(device, name, sat_facts):
 def _collect_re_facts(device, name, sat_facts):
     """Populate RE facts from get_route_engine_information."""
     try:
-        rsp = device.rpc.get_route_engine_information(
-            device_list=name, normalize=True
-        )
+        rsp = device.rpc.get_route_engine_information(device_list=name, normalize=True)
         if rsp is None or rsp is True:
             return
         sat_dev = _get_sat_dev(rsp, name)
@@ -96,18 +90,15 @@ def _collect_re_facts(device, name, sat_facts):
 def _collect_chassis_facts(device, name, sat_facts):
     """Populate chassis inventory facts from get_chassis_inventory."""
     try:
-        rsp = device.rpc.get_chassis_inventory(
-            device_list=name, normalize=True
-        )
+        rsp = device.rpc.get_chassis_inventory(device_list=name, normalize=True)
         if rsp is None or rsp is True:
             return
         sat_dev = _get_sat_dev(rsp, name)
         if sat_dev is None:
             return
-        sat_facts["serialnumber"] = (
-            sat_dev.findtext(".//chassis[1]/serial-number")
-            or sat_dev.findtext('.//chassis-module[name="Midplane"]/serial-number')
-        )
+        sat_facts["serialnumber"] = sat_dev.findtext(
+            ".//chassis[1]/serial-number"
+        ) or sat_dev.findtext('.//chassis-module[name="Midplane"]/serial-number')
     except Exception:
         pass
 

lib/jnpr/junos/ofacts/satellites.py

@@ -1,8 +1,6 @@
 def _get_sat_dev(rsp, name):
     """Return the <satellite-device> element matching *name*, or first found."""
-    sat_dev = rsp.find(
-        ".//satellite-device[satellite-mgmt-ip='{}']".format(name)
-    )
+    sat_dev = rsp.find(".//satellite-device[satellite-mgmt-ip='{}']".format(name))
     return sat_dev if sat_dev is not None else rsp.find(".//satellite-device")
 
 
@@ -140,20 +138,17 @@ def facts_satellites(junos, facts):
                     if inv_rsp is not None and inv_rsp is not True:
                         sat_dev = _get_sat_dev(inv_rsp, name)
                         if sat_dev is not None:
-                            sat_facts["serialnumber"] = (
-                                sat_dev.findtext(".//chassis[1]/serial-number")
-                                or sat_dev.findtext(
-                                    './/chassis-module[name="Midplane"]/serial-number'
-                                )
+                            sat_facts["serialnumber"] = sat_dev.findtext(
+                                ".//chassis[1]/serial-number"
+                            ) or sat_dev.findtext(
+                                './/chassis-module[name="Midplane"]/serial-number'
                             )
                 except Exception:
                     pass
 
                 # --- virtual chassis facts ---
                 try:
-                    vc_rsp = junos.rpc.get_virtual_chassis_information(
-                        device_list=name
-                    )
+                    vc_rsp = junos.rpc.get_virtual_chassis_information(device_list=name)
                     if vc_rsp is not None and vc_rsp is not True:
                         sat_dev = _get_sat_dev(vc_rsp, name)
                         if sat_dev is not None and sat_dev.find(".//rpc-error") is None:

lib/jnpr/junos/utils/sw.py

@@ -207,9 +207,9 @@ def _install_on_satellites(
                         v_ok = True
                     else:
                         overall_ok = False
-                        overall_msg += (
-                            "\nSatellite %s: validation raised error: %s"
-                            % (sat_name, str(e))
+                        overall_msg += "\nSatellite %s: validation raised error: %s" % (
+                            sat_name,
+                            str(e),
                         )
                         continue
                 if v_ok is not True:

tests/unit/facts/test_get_jnu_satellites_information.py

@@ -72,9 +72,7 @@ def _mock_satellites_down(self, *args, **kwargs):
         if not args:
             return None
         if args[0].tag == "get-jnu-satellites-information":
-            return self._read_file(
-                "satellites_down_get-jnu-satellites-information.xml"
-            )
+            return self._read_file("satellites_down_get-jnu-satellites-information.xml")
         return None
 
     def _mock_satellites_rpc_error(self, *args, **kwargs):