From c9d06b2527595256824e69169f7703dbf2ceb265 Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 9 Nov 2026 05:22:56 +0000 Subject: [PATCH 1/4] refactor(integration): let the container autowire the case-token and analytics-series controllers Both controllers were hand-wired in BuiltinIntegrationServices, the only file outside lib/Controller that named them. Their dependencies are all container-resolvable (the service interfaces are bound in ContractBindings), so the hand-wired entries go and the controllers autowire like every other controller. AnalyticsSeriesController takes the app id from AppIdentity instead of receiving it. Assisted-by: ClaudeCode:claude-opus-5-5 --- lib/Controller/AnalyticsSeriesController.php | 5 ++--- .../Integration/BuiltinIntegrationServices.php | 11 ----------- .../BuiltinIntegrationProviderRegistrationTest.php | 10 ---------- .../AnalyticsSeriesControllerGoldenTest.php | 2 +- .../Service/Integration/IntegrationRegistrarTest.php | 2 -- 5 files changed, 3 insertions(+), 27 deletions(-) diff --git a/lib/Controller/AnalyticsSeriesController.php b/lib/Controller/AnalyticsSeriesController.php index 50dcbd84b307..e5ef9dbca299 100644 --- a/lib/Controller/AnalyticsSeriesController.php +++ b/lib/Controller/AnalyticsSeriesController.php @@ -36,6 +36,7 @@ namespace OCA\OpenRegister\Controller; +use OCA\OpenRegister\Kernel\Contracts\AppIdentity; use OCA\OpenRegister\Service\AnalyticsSeriesServiceInterface; use OCP\AppFramework\Controller; use OCP\AppFramework\Http; @@ -52,18 +53,16 @@ class AnalyticsSeriesController extends Controller { /** * Constructor. * - * @param string $appName App name (injected by NC). * @param IRequest $request Current request. * @param AnalyticsSeriesServiceInterface $seriesService Series register/fetch service. * * @return void */ public function __construct( - string $appName, IRequest $request, private AnalyticsSeriesServiceInterface $seriesService, ) { - parent::__construct(appName: $appName, request: $request); + parent::__construct(appName: AppIdentity::APP_ID, request: $request); }//end __construct() /** diff --git a/lib/Service/Integration/BuiltinIntegrationServices.php b/lib/Service/Integration/BuiltinIntegrationServices.php index 2b00b349a9fd..e7eb576a918d 100644 --- a/lib/Service/Integration/BuiltinIntegrationServices.php +++ b/lib/Service/Integration/BuiltinIntegrationServices.php @@ -208,12 +208,6 @@ final class BuiltinIntegrationServices { 'logger' => \Psr\Log\LoggerInterface::class, 'container' => self::CONTAINER, ], - \OCA\OpenRegister\Controller\CaseTokenController::class => [ - 'request' => \OCP\IRequest::class, - 'tokenService' => \OCA\OpenRegister\Service\CaseTokenService::class, - 'throttler' => \OCP\Security\Bruteforce\IThrottler::class, - 'logger' => \Psr\Log\LoggerInterface::class, - ], // @spec openspec/specs/integration-leaf-foundation/spec.md \OCA\OpenRegister\Service\AnalyticsSeriesService::class => [ 'mapper' => \OCA\OpenRegister\Db\AnalyticsSeriesMapperInterface::class, @@ -221,11 +215,6 @@ final class BuiltinIntegrationServices { 'userSession' => \OCP\IUserSession::class, 'groupManager' => \OCP\IGroupManager::class, ], - \OCA\OpenRegister\Controller\AnalyticsSeriesController::class => [ - 'appName' => self::APP_NAME, - 'request' => \OCP\IRequest::class, - 'seriesService' => \OCA\OpenRegister\Service\AnalyticsSeriesService::class, - ], // @spec openspec/specs/integration-bookmarks/spec.md \OCA\OpenRegister\Service\Integration\Providers\BookmarksProvider::class => [ 'bookmarkLinkMapper' => \OCA\OpenRegister\Db\BookmarkLinkMapperInterface::class, diff --git a/tests/Unit/AppInfo/BuiltinIntegrationProviderRegistrationTest.php b/tests/Unit/AppInfo/BuiltinIntegrationProviderRegistrationTest.php index 00c9747e7a61..d0ef20bb8779 100644 --- a/tests/Unit/AppInfo/BuiltinIntegrationProviderRegistrationTest.php +++ b/tests/Unit/AppInfo/BuiltinIntegrationProviderRegistrationTest.php @@ -155,22 +155,12 @@ class BuiltinIntegrationProviderRegistrationTest extends TestCase { 'OCP\IURLGenerator', 'Psr\Log\LoggerInterface', ], - 'OCA\OpenRegister\Controller\CaseTokenController' => [ - 'OCP\IRequest', - 'OCA\OpenRegister\Service\CaseTokenService', - 'OCP\Security\Bruteforce\IThrottler', - 'Psr\Log\LoggerInterface', - ], 'OCA\OpenRegister\Service\AnalyticsSeriesService' => [ 'OCA\OpenRegister\Db\AnalyticsSeriesMapperInterface', 'OCA\OpenRegister\Service\Integration\IntegrationRegistry', 'OCP\IUserSession', 'OCP\IGroupManager', ], - 'OCA\OpenRegister\Controller\AnalyticsSeriesController' => [ - 'OCP\IRequest', - 'OCA\OpenRegister\Service\AnalyticsSeriesService', - ], 'OCA\OpenRegister\Service\Integration\Providers\BookmarksProvider' => [ 'OCA\OpenRegister\Db\BookmarkLinkMapperInterface', 'OCP\App\IAppManager', diff --git a/tests/Unit/Controller/AnalyticsSeriesControllerGoldenTest.php b/tests/Unit/Controller/AnalyticsSeriesControllerGoldenTest.php index 6e0218b2a1d9..3e0823c4e864 100644 --- a/tests/Unit/Controller/AnalyticsSeriesControllerGoldenTest.php +++ b/tests/Unit/Controller/AnalyticsSeriesControllerGoldenTest.php @@ -43,7 +43,7 @@ protected function setUp(): void { parent::setUp(); $this->request = $this->createMock(IRequest::class); $this->service = $this->createMock(AnalyticsSeriesService::class); - $this->controller = new AnalyticsSeriesController('openregister', $this->request, $this->service); + $this->controller = new AnalyticsSeriesController($this->request, $this->service); } public function testRegisterAppliesDefaultsForAnEmptyBody(): void { diff --git a/tests/Unit/Service/Integration/IntegrationRegistrarTest.php b/tests/Unit/Service/Integration/IntegrationRegistrarTest.php index bdc4e6fbeb33..5f645393c9f8 100644 --- a/tests/Unit/Service/Integration/IntegrationRegistrarTest.php +++ b/tests/Unit/Service/Integration/IntegrationRegistrarTest.php @@ -66,9 +66,7 @@ public function testRegistersTheServicesInOrder(): void { 'OCA\OpenRegister\Service\Integration\Providers\SharesProvider', 'OCA\OpenRegister\Service\ShareLinkService', 'OCA\OpenRegister\Service\CaseTokenService', - 'OCA\OpenRegister\Controller\CaseTokenController', 'OCA\OpenRegister\Service\AnalyticsSeriesService', - 'OCA\OpenRegister\Controller\AnalyticsSeriesController', 'OCA\OpenRegister\Service\Integration\Providers\BookmarksProvider', 'OCA\OpenRegister\Service\Integration\Providers\TalkProvider', 'OCA\OpenRegister\Service\TalkLinkService', From 15be766a3dbc5f9d9fb4938b45d0ae9ff657cff5 Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 9 Nov 2026 05:23:45 +0000 Subject: [PATCH 2/4] refactor(formats): hand the BSN elfproef out behind the format interface NlPatternSet in lib/Files was the only file outside lib/Formats that named BsnFormat. It now types the check as Opis' Format and gets the default from IdentifierFormats, a factory inside lib/Formats. Assisted-by: ClaudeCode:claude-opus-5-5 --- .../PatternSet/NlPatternSet.php | 19 +++++--- lib/Formats/IdentifierFormats.php | 44 +++++++++++++++++ tests/Unit/Formats/IdentifierFormatsTest.php | 48 +++++++++++++++++++ 3 files changed, 105 insertions(+), 6 deletions(-) create mode 100644 lib/Formats/IdentifierFormats.php create mode 100644 tests/Unit/Formats/IdentifierFormatsTest.php diff --git a/lib/Files/Service/TextExtraction/PatternSet/NlPatternSet.php b/lib/Files/Service/TextExtraction/PatternSet/NlPatternSet.php index f046ae529680..b3a9f3fa8f15 100644 --- a/lib/Files/Service/TextExtraction/PatternSet/NlPatternSet.php +++ b/lib/Files/Service/TextExtraction/PatternSet/NlPatternSet.php @@ -24,7 +24,8 @@ namespace OCA\OpenRegister\Files\Service\TextExtraction\PatternSet; -use OCA\OpenRegister\Formats\BsnFormat; +use OCA\OpenRegister\Formats\IdentifierFormats; +use Opis\JsonSchema\Format; use OCA\OpenRegister\Files\Service\TextExtraction\EntityRecognitionHandler; /** @@ -32,7 +33,7 @@ * * A BSN is a nine-digit token, written plain or in the groups 4-2-3 or 3-2-4 * separated by a dot or a space, that passes the elfproef. The elfproef is - * the one in {@see BsnFormat}; no second copy is written here. A nine-digit + * the one in the Formats component; no second copy is written here. A nine-digit * token that fails it is not a BSN and is not reported. A BSN is reported as * {@see EntityRecognitionHandler::ENTITY_TYPE_SSN}, the citizen service number * type the risk service rates very high. @@ -58,14 +59,20 @@ class NlPatternSet implements JurisdictionPatternSet { */ private const BSN_CONFIDENCE = 0.85; + /** + * The elfproef. + * + * @var Format + */ + private readonly Format $bsnFormat; + /** * Constructor. * - * @param BsnFormat $bsnFormat The elfproef. + * @param Format|null $bsnFormat The elfproef; the Formats component's BSN check when null. */ - public function __construct( - private readonly BsnFormat $bsnFormat = new BsnFormat(), - ) { + public function __construct(?Format $bsnFormat=null) { + $this->bsnFormat = $bsnFormat ?? IdentifierFormats::bsn(); }//end __construct() /** diff --git a/lib/Formats/IdentifierFormats.php b/lib/Formats/IdentifierFormats.php new file mode 100644 index 000000000000..99f51142f1d4 --- /dev/null +++ b/lib/Formats/IdentifierFormats.php @@ -0,0 +1,44 @@ + + * @copyright 2026 Conduction B.V. + * @license EUPL-1.2 https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 + * + * @version GIT: + * + * @link https://OpenRegister.app + */ + +declare(strict_types=1); + +namespace OCA\OpenRegister\Formats; + +use Opis\JsonSchema\Format; + +/** + * Factory for the identifier checks of the Formats component. + */ +final class IdentifierFormats { + + /** + * The BSN elfproef. + * + * @return Format + */ + public static function bsn(): Format { + return new BsnFormat(); + }//end bsn() +}//end class diff --git a/tests/Unit/Formats/IdentifierFormatsTest.php b/tests/Unit/Formats/IdentifierFormatsTest.php new file mode 100644 index 000000000000..7042c3171ce2 --- /dev/null +++ b/tests/Unit/Formats/IdentifierFormatsTest.php @@ -0,0 +1,48 @@ + + * @copyright 2026 Conduction B.V. + * @license EUPL-1.2 https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 + * + * @version GIT: + * + * @link https://OpenRegister.app + */ + +declare(strict_types=1); + +namespace OCA\OpenRegister\Tests\Unit\Formats; + +use OCA\OpenRegister\Formats\BsnFormat; +use OCA\OpenRegister\Formats\IdentifierFormats; +use PHPUnit\Framework\TestCase; + +/** + * The factory hands out the component's own BSN check. + * + * @covers \OCA\OpenRegister\Formats\IdentifierFormats + */ +class IdentifierFormatsTest extends TestCase { + + /** + * The BSN check is the elfproef of BsnFormat. + * + * @return void + */ + public function testBsnIsTheElfproef(): void { + $format = IdentifierFormats::bsn(); + + $this->assertInstanceOf(BsnFormat::class, $format); + $this->assertTrue($format->validate('111222333')); + $this->assertFalse($format->validate('111222334')); + }//end testBsnIsTheElfproef() +}//end class From 45e47902fa24bfc5baf5c63c7f5093c92c588345 Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 9 Nov 2026 05:24:49 +0000 Subject: [PATCH 3/4] refactor(push,contextchat): keep the push channel names and the context-chat listener inside their components NotifyPushListener now reads the channel names from the PushChannels interface (PushEvents implements it, so PushEvents::OR_OBJECT keeps working). The context-chat content-provider listener is registered by ContextChatRegistrar, which FlowsListenerRegistrar calls at the same point, so the listener order is unchanged. Assisted-by: ClaudeCode:claude-opus-5-5 --- lib/ContextChat/ContextChatRegistrar.php | 21 +++++- lib/Listener/NotifyPushListener.php | 10 +-- .../Registrar/FlowsListenerRegistrar.php | 8 +-- lib/Push/PushChannels.php | 70 +++++++++++++++++++ lib/Push/PushEvents.php | 37 +--------- .../Architecture/K25InterfaceBindingsTest.php | 55 +++++++++++++++ 6 files changed, 156 insertions(+), 45 deletions(-) create mode 100644 lib/Push/PushChannels.php create mode 100644 tests/Unit/Architecture/K25InterfaceBindingsTest.php diff --git a/lib/ContextChat/ContextChatRegistrar.php b/lib/ContextChat/ContextChatRegistrar.php index 750f053793d8..573b81552823 100644 --- a/lib/ContextChat/ContextChatRegistrar.php +++ b/lib/ContextChat/ContextChatRegistrar.php @@ -25,7 +25,8 @@ use OCP\AppFramework\Bootstrap\IRegistrationContext; /** - * Binds the interfaces other components type against to the ContextChat classes. + * Binds the interfaces other components type against to the ContextChat classes, + * and registers the component's event listeners. * * An alias only names the class; nothing here loads ContentProvider, whose * parent interface is missing before Nextcloud 32. @@ -55,4 +56,22 @@ public static function register(IRegistrationContext $context): void { $context->registerServiceAlias($contract, $service); } }//end register() + + /** + * Register the ContextChat component's event listeners. + * + * The content provider registers softly gated by + * IContentManager::isContextChatAvailable() inside the listener body, so an + * instance without the `context_chat` app installed is entirely unaffected. + * `::class` does not load the event, whose class is missing before Nextcloud 32. + * + * @param IRegistrationContext $context The registration context. + * + * @return void + * + * @spec exclude Container wiring; no behaviour of its own. + */ + public static function registerListeners(IRegistrationContext $context): void { + $context->registerEventListener(\OCP\ContextChat\Events\ContentProviderRegisterEvent::class, ContentProviderRegistrationListener::class); + }//end registerListeners() }//end class diff --git a/lib/Listener/NotifyPushListener.php b/lib/Listener/NotifyPushListener.php index c4a657db5be9..4c808f65267b 100644 --- a/lib/Listener/NotifyPushListener.php +++ b/lib/Listener/NotifyPushListener.php @@ -52,7 +52,7 @@ use OCA\OpenRegister\Event\ObjectDeletedEvent; use OCA\OpenRegister\Event\ObjectUpdatedEvent; use OCA\OpenRegister\Listener\Support\PushSlugResolver; -use OCA\OpenRegister\Push\PushEvents; +use OCA\OpenRegister\Push\PushChannels; use OCA\OpenRegister\Service\Object\ObjectReadersInterface; use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; @@ -291,7 +291,7 @@ private function accumulateBatchEntry(ObjectEntity $object): void { private function dispatchPushes(string $action, ObjectEntity $object, object $queue): void { $payload = $this->lifecyclePayload(action: $action, object: $object); $userIds = $this->permissionHandler->getReadableByUsers(object: $object); - $objectChannel = PushEvents::OR_OBJECT . '-' . $payload['uuid']; + $objectChannel = PushChannels::OR_OBJECT . '-' . $payload['uuid']; $pushed = $this->pushToUsers(queue: $queue, userIds: $userIds, channel: $objectChannel, payload: $payload); $collectionChannel = $this->collectionChannel(payload: $payload); @@ -339,7 +339,7 @@ private function collectionChannel(array $payload): ?string { return null; } - return PushEvents::OR_COLLECTION . '-' . $payload['register'] . '-' . $payload['schema']; + return PushChannels::OR_COLLECTION . '-' . $payload['register'] . '-' . $payload['schema']; }//end collectionChannel() /** @@ -519,7 +519,7 @@ private static function broadcastCollection(object $queue, array $entry): void { $queue->push( 'notify_custom', [ - 'message' => PushEvents::OR_COLLECTION . '-' . $entry['register'] . '-' . $entry['schema'], + 'message' => PushChannels::OR_COLLECTION . '-' . $entry['register'] . '-' . $entry['schema'], 'body' => [ 'action' => 'batch', 'register' => $entry['register'], @@ -608,6 +608,6 @@ public function pushPresence(ObjectEntity $object, array $present): bool { $payload = ['action' => 'presence', 'uuid' => $uuid, 'present' => array_values($present)]; $readers = $this->permissionHandler->getReadableByUsers(object: $object); - return $this->pushToUsers(queue: $queue, userIds: $readers, channel: PushEvents::OR_OBJECT . '-' . $uuid, payload: $payload); + return $this->pushToUsers(queue: $queue, userIds: $readers, channel: PushChannels::OR_OBJECT . '-' . $uuid, payload: $payload); }//end pushPresence() }//end class diff --git a/lib/Listener/Registrar/FlowsListenerRegistrar.php b/lib/Listener/Registrar/FlowsListenerRegistrar.php index c6cb640dedcd..b547ea79c188 100644 --- a/lib/Listener/Registrar/FlowsListenerRegistrar.php +++ b/lib/Listener/Registrar/FlowsListenerRegistrar.php @@ -20,7 +20,7 @@ namespace OCA\OpenRegister\Listener\Registrar; -use OCA\OpenRegister\ContextChat\ContentProviderRegistrationListener; +use OCA\OpenRegister\ContextChat\ContextChatRegistrar; use OCA\OpenRegister\Event\BulkActionRegistrationEvent; use OCA\OpenRegister\Event\ObjectLockedEvent; use OCA\OpenRegister\Event\ObjectRevertedEvent; @@ -141,10 +141,8 @@ private static function registerFileAndDiscoveryListeners(IRegistrationContext $ $context->registerEventListener(\OCP\OCM\Events\ResourceTypeRegisterEvent::class, OcmResourceTypeListener::class); // Register OpenRegister as a Context Chat (OCP\ContextChat) content - // provider — softly gated by IContentManager::isContextChatAvailable() - // inside the listener body, so an instance without the `context_chat` - // app installed is entirely unaffected. - $context->registerEventListener(\OCP\ContextChat\Events\ContentProviderRegisterEvent::class, ContentProviderRegistrationListener::class); + // provider; the ContextChat component names its own listener. + ContextChatRegistrar::registerListeners(context: $context); }//end registerFileAndDiscoveryListeners() /** diff --git a/lib/Push/PushChannels.php b/lib/Push/PushChannels.php new file mode 100644 index 000000000000..1df9f513b1e6 --- /dev/null +++ b/lib/Push/PushChannels.php @@ -0,0 +1,70 @@ + + * @copyright 2024 Conduction B.V. + * @license EUPL-1.2 https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 + * + * @version GIT: + * + * @link https://OpenRegister.app + */ + +declare(strict_types=1); + +namespace OCA\OpenRegister\Push; + +/** + * The notify_push channel names OpenRegister pushes on. + * + * Consumers (e.g. @conduction/nextcloud-vue) subscribe to: + * - `or-object-{uuid}` — single-object updates + * - `or-collection-{register-slug}-{schema-slug}` — collection-level invalidation (create/delete) + */ +interface PushChannels { + + /** + * Base event string for single-object updates. + * + * Append `-{uuid}` when pushing to specific listeners: + * ``` + * $eventString = PushChannels::OR_OBJECT . '-' . $uuid; + * ``` + * + * Fired on every object lifecycle action (create, update, delete). + * + * @var string + */ + public const OR_OBJECT = 'or-object'; + + /** + * Base event string for collection-level invalidation. + * + * Append `-{register-slug}-{schema-slug}` when pushing to collection listeners: + * ``` + * $eventString = PushChannels::OR_COLLECTION . '-' . $registerSlug . '-' . $schemaSlug; + * ``` + * + * Fired on create and delete only (not on update, to avoid redundant + * collection refreshes when only content changes). + * + * @var string + */ + public const OR_COLLECTION = 'or-collection'; +}//end interface diff --git a/lib/Push/PushEvents.php b/lib/Push/PushEvents.php index cdce7739bed7..6de207e7567f 100644 --- a/lib/Push/PushEvents.php +++ b/lib/Push/PushEvents.php @@ -33,39 +33,8 @@ /** * Constants for notify_push event strings used by OpenRegister. * - * Consumers (e.g. @conduction/nextcloud-vue) subscribe to: - * - `or-object-{uuid}` — single-object updates - * - `or-collection-{register-slug}-{schema-slug}` — collection-level invalidation (create/delete) + * The names themselves live on {@see PushChannels}; this class keeps them + * reachable as PushEvents::OR_OBJECT and PushEvents::OR_COLLECTION. */ -class PushEvents { - - /** - * Base event string for single-object updates. - * - * Append `-{uuid}` when pushing to specific listeners: - * ``` - * $eventString = PushEvents::OR_OBJECT . '-' . $uuid; - * ``` - * - * Fired on every object lifecycle action (create, update, delete). - * - * @var string - */ - public const OR_OBJECT = 'or-object'; - - /** - * Base event string for collection-level invalidation. - * - * Append `-{register-slug}-{schema-slug}` when pushing to collection listeners: - * ``` - * $eventString = PushEvents::OR_COLLECTION . '-' . $registerSlug . '-' . $schemaSlug; - * ``` - * - * Fired on create and delete only (not on update, to avoid redundant - * collection refreshes when only content changes). - * - * @var string - */ - public const OR_COLLECTION = 'or-collection'; - +class PushEvents implements PushChannels { }//end class diff --git a/tests/Unit/Architecture/K25InterfaceBindingsTest.php b/tests/Unit/Architecture/K25InterfaceBindingsTest.php new file mode 100644 index 000000000000..06791b57048b --- /dev/null +++ b/tests/Unit/Architecture/K25InterfaceBindingsTest.php @@ -0,0 +1,55 @@ + + * @copyright 2026 Conduction B.V. + * @license EUPL-1.2 https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 + * + * @version GIT: + * + * @link https://OpenRegister.app + */ + +declare(strict_types=1); + +namespace OCA\OpenRegister\Tests\Unit\Architecture; + +use OCA\OpenRegister\Push\PushChannels; +use OCA\OpenRegister\Push\PushEvents; +use PHPUnit\Framework\TestCase; + +/** + * PushChannels is a constants-only interface, so it has no container binding: + * the promise is that PushEvents implements it and still exposes the same names. + */ +final class K25InterfaceBindingsTest extends TestCase { + + /** + * PushEvents implements PushChannels. + * + * @return void + */ + public function testPushEventsImplementsPushChannels(): void { + $this->assertContains(PushChannels::class, class_implements(PushEvents::class)); + }//end testPushEventsImplementsPushChannels() + + /** + * The channel names did not change for consumers of either name. + * + * @return void + */ + public function testChannelNamesAreUnchanged(): void { + $this->assertSame('or-object', PushChannels::OR_OBJECT); + $this->assertSame('or-collection', PushChannels::OR_COLLECTION); + $this->assertSame(PushChannels::OR_OBJECT, PushEvents::OR_OBJECT); + $this->assertSame(PushChannels::OR_COLLECTION, PushEvents::OR_COLLECTION); + }//end testChannelNamesAreUnchanged() +}//end class From 7f79613dc5dfa183222c35c8161fbf37999b3c66 Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 9 Nov 2026 05:31:03 +0000 Subject: [PATCH 4/4] docs(formats): link IdentifierFormats to its spec Assisted-by: ClaudeCode:claude-opus-5-5 --- lib/Formats/IdentifierFormats.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/Formats/IdentifierFormats.php b/lib/Formats/IdentifierFormats.php index 99f51142f1d4..2ba5b53d4276 100644 --- a/lib/Formats/IdentifierFormats.php +++ b/lib/Formats/IdentifierFormats.php @@ -30,6 +30,8 @@ /** * Factory for the identifier checks of the Formats component. + * + * @spec openspec/specs/data-import-export/spec.md */ final class IdentifierFormats { @@ -37,6 +39,8 @@ final class IdentifierFormats { * The BSN elfproef. * * @return Format + * + * @spec openspec/specs/data-import-export/spec.md */ public static function bsn(): Format { return new BsnFormat();