From bef5c4abb4b0169de1e160919d88d8a03c72a722 Mon Sep 17 00:00:00 2001 From: Ruben van der Linde Date: Fri, 2 Oct 2026 17:07:42 +0200 Subject: [PATCH] test(generator): count passphrase words without splitting on hyphens Four EFF words carry a hyphen (drop-down, felt-tip, t-shirt, yo-yo), so splitting a random default passphrase on '-' failed now and then. The default is checked with a fixed random source; the content checks use a space as separator. --- tests/vitest/generator.spec.js | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/tests/vitest/generator.spec.js b/tests/vitest/generator.spec.js index 2fa2a2771..f931befdc 100644 --- a/tests/vitest/generator.spec.js +++ b/tests/vitest/generator.spec.js @@ -256,8 +256,15 @@ describe('passphrase generation', () => { }) it('defaults to five list words joined by hyphens', () => { + // A fixed random source: four list words carry a hyphen themselves + // (drop-down, felt-tip, t-shirt, yo-yo), so splitting a random + // default passphrase on "-" cannot count its words. + const first = () => 0 + expect(generatePassphrase({}, null, first)).toBe( + Array(5).fill(EFF_LARGE_WORDLIST[0]).join('-'), + ) repeat(() => { - const words = generatePassphrase().split('-') + const words = generatePassphrase({ separator: ' ' }).split(' ') expect(words).toHaveLength(5) for (const word of words) { expect(WORDS.has(word)).toBe(true) @@ -275,10 +282,11 @@ describe('passphrase generation', () => { repeat(() => { const phrase = generatePassphrase({ words: 4, + separator: ' ', capitalise: true, includeNumber: true, }) - const words = phrase.split('-') + const words = phrase.split(' ') expect(words.every((w) => /^[A-Z]/.test(w))).toBe(true) expect(phrase.match(/[0-9]/g)).toHaveLength(1) })