From 832c746957cfb63e44ae23a02cc684a72c0b6715 Mon Sep 17 00:00:00 2001 From: Ruben van der Linde Date: Wed, 5 Aug 2026 23:45:35 +0200 Subject: [PATCH 1/2] chore(ci): move hydra-gates-ref v1.3.0 -> v1.4.0 A pinned `hydra-gates-ref` is a silent expiry date on every upstream fix: this repo cannot receive a gate-package change until this line moves. v1.4.0 is the latest tag and the first one that carries `hydra-gates/scripts/axe-run.cjs` (verified absent at v1.3.0), so it is also the first that has ConductionNL/.github#168 axe DOM scoping and ConductionNL/.github#165 gate-46 fix. `enable-axe` is deliberately NOT enabled in this commit. Ordering matters: the ref lands first, enabling axe is a separate decision. --- .github/workflows/code-quality.yml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml index 03dd23719b..637d6f477a 100644 --- a/.github/workflows/code-quality.yml +++ b/.github/workflows/code-quality.yml @@ -216,7 +216,16 @@ jobs: # reproducible and a later gate change cannot move this repo's verdict # without a commit here. enable-hydra-gates: true - hydra-gates-ref: v1.3.0 + hydra-gates-ref: v1.4.0 + # PIN MOVED v1.3.0 -> v1.4.0 (fleet consumer-ref sweep, 2026-08-05). + # A pinned ref is a silent expiry date on every upstream fix: this repo + # cannot receive a gate-package fix until this line moves. v1.4.0 is the + # latest tag and the FIRST one carrying `hydra-gates/scripts/axe-run.cjs` + # (verified absent at v1.3.0), so it is also the first that has #168's + # axe DOM scoping and #165's gate-46 fix. + # `enable-axe` is deliberately still NOT set — a vanilla Nextcloud 34 + # reports serious/critical violations on core's OWN routes that DOM + # scoping does not remove. Enabling axe is a separate decision. # ── Coverage ratchet ───────────────────────────────────────────────── # `enable-coverage-guard` defaults to FALSE in the shared workflow, so From c797edfe19f75af11d23276e87d41c644b393bd0 Mon Sep 17 00:00:00 2001 From: Ruben van der Linde Date: Thu, 6 Aug 2026 07:38:50 +0200 Subject: [PATCH 2/2] =?UTF-8?q?chore(ci):=20stop=20pinning=20hydra-gates?= =?UTF-8?q?=20=E2=80=94=20track=20the=20package=20at=20@main?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Removes `hydra-gates-ref` entirely instead of moving it v1.3.0 -> v1.4.0. The shared workflow already defaults the input to @main, and this repo consumes `ConductionNL/.github/.github/workflows/quality.yml@main`, so both sides now move together: a gate-package fix reaches this repo with no commit here. A pin is a silent expiry date. 22 repos sat on v1.0.1 while 16 gates were dead fleet-wide and every one of them reported PASS (.github#159), and a default flipped at @main later reached those same old runners and failed them on gates they had no subject matter for (.github#173). Bumping the pin is a treadmill that reintroduces the same failure mode on the next release. The pin-justifying comment block is replaced with a short note saying why there is no ref here and how to reintroduce one deliberately. The rationale for `enable-hydra-gates: true` is kept, as is `enable-axe` being left off and this repo's explicit `hydra-gates-require-full-coverage: false`. --- .github/workflows/code-quality.yml | 47 +++++++----------------------- 1 file changed, 11 insertions(+), 36 deletions(-) diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml index 637d6f477a..3edee3a2b9 100644 --- a/.github/workflows/code-quality.yml +++ b/.github/workflows/code-quality.yml @@ -186,43 +186,18 @@ jobs: # ── Hydra mechanical gates ─────────────────────────────────────────── # `enable-hydra-gates` defaults to FALSE, so this tier has never executed # here — the job reported `skipped`, which the Quality Report renders - # identically to a pass. Pinned to v1.0.1 so a change to the gate package - # cannot move this repo's verdict without a commit here. - # `enable-axe` deliberately NOT set: a vanilla Nextcloud 34 already carries - # serious/critical violations from core's own UI. - # - # v1.0.1 -> v1.3.0 (ConductionNL/.github#159). Two defects, one bump. - # - # 1. STALE. v1.0.1 is `f4d9756` (2026-08-03) and predates three gate - # fixes, so every Hydra Gates run this repo has ever made executed a - # script in which 16 gates reported PASS when their helper never ran - # (#147), gate-33 had no axe report to read and never said so (#148), - # and gates 6 and 7 reported PASS on an EMPTY scope (#149). A gate - # that reports PASS without running emits a tick identical to a real - # one, which is why nothing in this repo's history shows it. - # - # 2. RED. quality.yml is referenced `@main` while this package is - # PINNED, so the two can desync — and on 2026-08-05 they did. #164 - # flipped `hydra-gates-require-full-coverage` to default TRUE, but - # the accounting that makes that flag survivable (NOT APPLICABLE, as - # distinct from a structural or a wiring gap) ships in the PACKAGE. - # So every pin older than `f7eaf2a` now fails the coverage assertion - # for gates it has no subject matter for. Measured diff-scoped, - # exactly as CI scopes it: - # v1.0.1 exit 98 FAIL — "GATES THAT DID NOT RUN: 24 33" - # v1.3.0 exit 0 PASS — those gates named NOT APPLICABLE - # - # v1.3.0 is `f7eaf2a` = .github@main, tagged so the ref stays - # reproducible and a later gate change cannot move this repo's verdict - # without a commit here. + # identically to a pass. enable-hydra-gates: true - hydra-gates-ref: v1.4.0 - # PIN MOVED v1.3.0 -> v1.4.0 (fleet consumer-ref sweep, 2026-08-05). - # A pinned ref is a silent expiry date on every upstream fix: this repo - # cannot receive a gate-package fix until this line moves. v1.4.0 is the - # latest tag and the FIRST one carrying `hydra-gates/scripts/axe-run.cjs` - # (verified absent at v1.3.0), so it is also the first that has #168's - # axe DOM scoping and #165's gate-46 fix. + # No `hydra-gates-ref` here on purpose. The shared workflow defaults it + # to @main, and this workflow is itself consumed at @main, so the two + # sides move together and a gate fix reaches this repo without a commit + # in this repo. A pin is a silent expiry date: 22 repos sat on v1.0.1 and + # 16 gates were dead fleet-wide while every one reported PASS (.github#159), + # and a default flipped at @main later reached those old runners and made + # them red on gates they had no subject matter for (.github#173). + # To hold this repo still for a specific reason, set the input explicitly + # and say why — it is still honoured. To roll back for everyone, revert on + # ConductionNL/.github main. # `enable-axe` is deliberately still NOT set — a vanilla Nextcloud 34 # reports serious/critical violations on core's OWN routes that DOM # scoping does not remove. Enabling axe is a separate decision.