From 4cc2ebc49587adb712fbb5f449a84f6adbaf2689 Mon Sep 17 00:00:00 2001 From: Ruben van der Linde Date: Wed, 9 Sep 2026 09:41:15 +0200 Subject: [PATCH 1/2] fix(ci): build an additional app's frontend before the browser jobs run MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The browser jobs clone a sibling app, install its composer dependencies, and stop. The step that runs `npm run build` is scoped to `inputs.app-name`, and every Conduction app gitignores its webpack output — openregister's .gitignore carries a bare `/js/` — so the sibling has been installed with no compiled frontend in every E2E and journeydoc run this workflow has produced. Nothing errors when that happens. `Util::addInitScript` still emits the script tag, the request falls through to index.php, and the browser receives an HTML error page with status 200. The sibling app then contributes nothing to any page, and the CONSUMING app's specs go red for it. Measured on dossiq: openregister-integration-global.js is the bundle that installs window.OCA.OpenRegister.integrations, so every type: "integration" widget in a consuming manifest resolved to nothing on CI and resolved fine on any developer box, where a build had once been run. 39 repos declare an additional app and enable a browser job. The step counts the emitted files rather than trusting the exit code: a build that exits 0 and writes nothing is the state this exists to remove. phpunit's additional-app checkout is deliberately untouched — it renders no pages and pays nothing for this. --- .github/workflows/quality.yml | 170 ++++++++++++++++++++++++++++++++++ 1 file changed, 170 insertions(+) diff --git a/.github/workflows/quality.yml b/.github/workflows/quality.yml index d18ca37ff..110080cba 100644 --- a/.github/workflows/quality.yml +++ b/.github/workflows/quality.yml @@ -4702,6 +4702,91 @@ jobs: npm ci fi + - name: Build additional app frontends + # A SIBLING APP WAS INSTALLED WITH NO COMPILED FRONTEND, IN EVERY + # BROWSER JOB THIS WORKFLOW HAS EVER RUN. + # + # `Checkout additional apps` clones the sibling and installs its + # composer dependencies, and stops there. The `Build app frontend` + # step further down is scoped to `inputs.app-name` — it builds the app + # under test and nothing else. Every Conduction app gitignores its + # webpack output (openregister's `.gitignore` carries a bare `/js/`), + # so the clone arrives with no bundle and nothing ever compiles one. + # + # THE FAILURE IS SILENT, WHICH IS WHY IT LASTED. A Nextcloud app whose + # bundle is missing does not 404: `Util::addScript` / `addInitScript` + # still emit the