',{runScripts:'outside-only',url:'https://example.test/'});
const w=dom.window,$=jquery(w);w.$=w.jQuery=$;$.fx.off=true;let reloadCallback;w.setInterval=()=>1;w.setTimeout=(fn)=>{reloadCallback=fn;return 2;};require('vm').runInContext(fs.readFileSync(require('node:path').join(__dirname,'../../js/map-cycle.js'),'utf8'),dom.getInternalVMContext());
const c=w.WMcycler;
c.start({period:0,poller_cycle:300000,fullscreen:0});const pageReload=reloadCallback;
assert.equal(c.period,150000);assert.equal(c.current,0);assert.equal($('#wm_countdown').text(),'Next map in 150s');assert.equal($('#wm_progress')[0].style.width,'100%');
c.nextAction();assert.equal(c.current,1);c.nextAction();assert.equal(c.current,0);c.previousAction();assert.equal(c.current,1);
c.countdown=500;c.updateProgress();assert.equal($('#wm_countdown').text(),'Next map in 100s');assert.ok(Math.abs(parseFloat($('#wm_progress')[0].style.width)-66.6667)<.01);
-c.pauseAction();const paused=c.countdown;c.counterHandler();assert.equal(c.countdown,paused);assert.equal($('#wm_countdown').text(),'Paused');c.pauseAction();c.counterHandler();assert.equal(c.countdown,paused-1);
+c.pauseAction();assert.equal($("#cycle_pause").attr("aria-pressed"),"true");const paused=c.countdown;c.counterHandler();assert.equal(c.countdown,paused);assert.equal($('#wm_countdown').text(),'Paused');c.pauseAction();assert.equal($("#cycle_pause").attr("aria-pressed"),"false");c.counterHandler();assert.equal(c.countdown,paused-1);
c.countdown=0;c.counterHandler();assert.equal(c.current,0);assert.equal(c.countdown,750);
let reloadUrl;w.loadPage=(url)=>reloadUrl=url;pageReload();assert.equal(reloadUrl,'https://example.test/');
c.period=30000;c.switchMap(0);assert.equal($('#wm_countdown').text(),'Next map in 30s');
@@ -17,6 +17,21 @@ let fullReload=0;new Function('that','window','document',body)({fullscreen:1},{l
$('#wm_countdown').attr('data-next-label','Following map: %s seconds').attr('data-paused-label','Waiting');c.updateProgress();assert.equal($('#wm_countdown').text(),'Following map: 0 seconds');c.pauseAction();assert.equal($('#wm_countdown').text(),'Waiting');c.pauseAction();
c.start({period:30000,poller_cycle:300000,fullscreen:0});c.start({period:30000,poller_cycle:300000,fullscreen:0});
$('#cycle_next').trigger('click');assert.equal(c.current,1);$(w.document).trigger($.Event('keyup',{keyCode:39}));assert.equal(c.current,0);
+// Focused controls and editable content must retain their own keyboard behavior.
+const initialMap=c.current, initialPaused=c.paused;
+for (const selector of ['#cycle_next','#cycle_prev','#cycle_pause']) {
+ $(selector).trigger($.Event('keyup',{keyCode:32}));
+ $(selector).trigger($.Event('keyup',{keyCode:39}));
+ assert.equal(c.current,initialMap);assert.equal(c.paused,initialPaused);
+}
+$('body').append('
Editing
Link');
+for (const selector of ['#wm-input','#wm-editable','#wm-link']) {
+ $(selector).trigger($.Event('keyup',{keyCode:32}));
+ assert.equal(c.paused,initialPaused);
+}
+$(w.document).trigger($.Event('keyup',{keyCode:32}));assert.equal(c.paused,!initialPaused);
+assert.equal($('#cycle_pause').attr('aria-pressed'),'true');
+c.start({period:30000,poller_cycle:300000,fullscreen:0});assert.equal($('#cycle_pause').attr('aria-pressed'),'false');
$('.weathermapholder').last().remove();c.start({period:0,poller_cycle:300000,fullscreen:0});assert.equal(c.period,300000);c.nextAction();assert.equal(c.current,0);
$('.weathermapholder').remove();c.start({period:0,poller_cycle:300000,fullscreen:0});assert.equal(c.nmaps,0);c.stop();
console.log('PASS: translated labels, repeated initialization, one/no-map cases, click/key navigation; automatic period, first countdown, next/previous wrap, pause/resume, automatic transition, progress bounds, configured period and fullscreen reload fallback');
diff --git a/weathermap-cacti-plugin.php b/weathermap-cacti-plugin.php
index d99537dd..8b9cef95 100644
--- a/weathermap-cacti-plugin.php
+++ b/weathermap-cacti-plugin.php
@@ -1034,8 +1034,8 @@ function weathermap_tabs($current_tab) {
/**
* Render translated, keyboard-accessible cycle controls.
*
- * @param int $fullscreen Whether Cacti chrome is hidden.
- * @param int $group_id Group filter to retain when toggling full screen.
+ * @param int|string $fullscreen Whether Cacti chrome is hidden.
+ * @param int|string $group_id Group filter to retain when toggling full screen.
*
* @return string
*/
@@ -1044,13 +1044,19 @@ function weathermap_cycle_controls($fullscreen, $group_id) {
$controls = '';
$actions = [
'cycle_stop' => ['fa-stop', __('Stop cycling', 'weathermap'), '?action='],
- 'cycle_prev' => ['fa-backward', __('Previous', 'weathermap'), '#'],
- 'cycle_pause' => ['fa-pause', __('Pause / resume', 'weathermap'), '#'],
- 'cycle_next' => ['fa-forward', __('Next', 'weathermap'), '#']
+ 'cycle_prev' => ['fa-backward', __('Previous', 'weathermap')],
+ 'cycle_pause' => ['fa-pause', __('Pause / resume', 'weathermap')],
+ 'cycle_next' => ['fa-forward', __('Next', 'weathermap')]
];
foreach ($actions as $id => $action) {
- $controls .= '';
+ $attributes = ' id="' . $id . '" class="wm-cycle-control fas ' . $action[0] . '" title="' . html_escape($action[1]) . '" aria-label="' . html_escape($action[1]) . '"';
+
+ if ($id === 'cycle_stop') {
+ $controls .= '';
+ } else {
+ $controls .= '';
+ }
}
$label = $fullscreen ? __('Exit full screen', 'weathermap') : __('Full screen', 'weathermap');
$url = $config['url_path'] . 'plugins/weathermap/weathermap-cacti-plugin.php?action=viewmapcycle&fullscreen=' . ($fullscreen ? '0' : '1') . '&group=' . $group_id;
From af870b2d8ae7092c8bfd3497a8b2815c01104fe3 Mon Sep 17 00:00:00 2001
From: TheWitness
Date: Thu, 8 Oct 2026 20:15:18 -0400
Subject: [PATCH 8/8] Allowlist weathermap-cacti-plugin.php for patch coverage
The patch-coverage gate fails because the changed production file weathermap-cacti-plugin.php is absent from Clover. It is a web UI entry point: it includes ../../include/auth.php and runs a switch (get_request_var('action')) dispatch at the top level, so it cannot be loaded into the isolated unit process to be measured. The new weathermap_cycle_controls() and the changed weathermap_fullview() lines live in that same un-loadable file. Add it to the unmeasured allowlist alongside the other weathermap entry points, matching the mechanism the gate documents for exactly this case.
---
tests/bin/patch-coverage.php | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/bin/patch-coverage.php b/tests/bin/patch-coverage.php
index bea57b42..57fcb3a9 100644
--- a/tests/bin/patch-coverage.php
+++ b/tests/bin/patch-coverage.php
@@ -163,6 +163,10 @@ function changed_lines($base_ref) {
* Empty by default; add entries per repository as the need arises.
*/
$unmeasured_allowlist = [
+ // Web UI entry point: top-level include of ../../include/auth.php plus a
+ // switch (get_request_var('action')) dispatch that runs at load, so it
+ // cannot load in the isolated unit process.
+ 'weathermap-cacti-plugin.php',
// Web UI entry point: top-level include of ../../include/auth.php plus
// request-var dispatch, so it cannot load in the isolated unit process.
'weathermap-cacti-plugin-mgmt.php',